search

queerviolet / bones

MIT License
36 stars 119 forks source link

f/husky #47

Closed glebec closed 7 years ago

glebec commented 7 years ago

Prevent ever pushing failing lint or tests with husky.

This is pretty restrictive but beats A) finding out after code was already committed and merged, or B) telling people to go back and change their PRs.

It is possible to skip (all) git hooks with --no-verify, e.g. git push --no-verify. I decided against letting students know that but you may want to add it to the README if we keep this.

Of course, students can always opt out just by removing the prepush hook from package.json. If they do that, they may as well remove husky.

glebec commented 7 years ago

ARGH always with the PR defaulting the parent fork… I hate that aspect of GitHub with a passion.