search

queicherius / gw2api-client

Javascript wrapper for the official Guild Wars 2 API.
MIT License
47 stars 18 forks source link

PvP Leaderboards #15

Closed darthmaim closed 7 years ago

darthmaim commented 7 years ago

With the current implementation its not possible to get the leaderboards of the old pvp seasons, beacause the leaderboard was not called ladder, but legendary and guild (ref).

The name of future leaderboards might change again, so its probably a good idea to not hardcode the leaderboard name.

Edit: And another thing I just noticed, you haven't marked the leaderboard endpoint as paginated, but it is (example: requesting rank 200 (?page=199&page_size=1)).

queicherius commented 7 years ago

Thank you for catching that, both things fixed in v5.0.0.