queicherius / gw2api-client

Javascript wrapper for the official Guild Wars 2 API.
MIT License
47 stars 18 forks source link

Add /v2/gliders and /v2/account/gliders #20

Closed darthmaim closed 7 years ago

darthmaim commented 7 years ago

I hope the failing tests are just because I don't have redis running locally and because the API is down at the moment. Weird thing is, sometimes I have 49 failing tests, sometimes only 41. ¯\_(ツ)_/¯

I didn't add gliders to account blob yet.

Edit: And of course the failing tests locally preventing the linting to run… Amazingly all tests passed on travis.

codecov-io commented 7 years ago

Codecov Report

Merging #20 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #20   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          47     48    +1     
  Lines        1026   1038   +12     
=====================================
+ Hits         1026   1038   +12
Impacted Files Coverage Δ
src/endpoints/gliders.js 100% <100%> (ø)
src/client.js 100% <100%> (ø) :arrow_up:
src/endpoints/account.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b7f7664...d82aae3. Read the comment docs.

queicherius commented 7 years ago

Thanks! 👍 ❤️ I'll add the account blob thing. 😄