search

queicherius / gw2api-client

Javascript wrapper for the official Guild Wars 2 API.
MIT License
47 stars 18 forks source link

Add info about some bulk expanding do not allow all. #84

Closed Ecmelt closed 2 weeks ago

Ecmelt commented 2 weeks ago

Unsure too, because i thought of readme which actually has "this.supportsBulkAll = false" in the items example but that is not really a good explanation of what it does and so very easy to miss. There could be a test specifically populated with bulk expanding endpoints with a mock testing an all call. That could say check if it supports .all() when fails?

queicherius commented 2 weeks ago

Yeah maybe update https://github.com/queicherius/gw2api-client/blob/master/README.md#extending to add comments above each of the this.configValue = foo lines explaining what they do?