quelea-projection / Quelea

Open source projection software for churches.
https://quelea.org
GNU General Public License v3.0
160 stars 147 forks source link

Problems importing openyrics zip #155

Closed ond1 closed 10 months ago

ond1 commented 5 years ago

Hi,

Firstly I would like to say Quelea is a great software package, which I like using. I hope that I can contribute to the project in some way.

I have been trying to import openlyrics zip file but it is just not doing anything. The Importing status bar just moves backwards and forwards for a very long time. I have tried on version 2019.0 and 2019.1.

Is there anyway for me to check if something is failing in the importing of the XML files? Do you have a logger or is there a way to run Quelea in debug mode to see what is going on?

ond1 commented 5 years ago

Just to add: As a workaround I had to import the openlyrics files into OpenLP then import the songs into Quelea that way. but this is not ideal because some of the song taggings are lost.

berry120 commented 5 years ago

Could you attach the files you're trying to import here so we can take a look? Thanks!

On Fri, 14 Jun 2019, 08:17 ond1, notifications@github.com wrote:

Just to add: As a workaround I had to import the openlyrics files into OpenLP then import the songs into Quelea that way. but this is not ideal because some of the song taggings are lost.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/quelea-projection/Quelea/issues/155?email_source=notifications&email_token=ABZ6JDNHBESY277Q6NGGO5TP2NAXTA5CNFSM4HYFEVFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXV6C7I#issuecomment-501997949, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZ6JDMW6K3RVRROCBHUXODP2NAXTANCNFSM4HYFEVFA .

ond1 commented 5 years ago

Hi,

Here is a cut down version of the zip. For the
tags we have empty namespace. I will have to get rid of those in my XSLT 3.0 stylesheet. The stylesheet is used to go from an internal format to openlyrics.

ond1 commented 5 years ago

Hi,

I think I have resolved or atleast found a workaround. It looks like Quelea does not handle all the elements that I had in the openLyrics XML file. Is Quelea fully conformant to the OpenLyrics schema?

I removed the themes and the copyright elements

I noticed Quelea created a version 0.9 XML. Is there a 0.9 schema out there? On the website https://openlyrics.org/ I only see version 0.8.

berry120 commented 5 years ago

Sorry, this one seemed to drop off my radar. Afraid I still don't see a sample file attached however?

It should be fully conformant, if it's not then it's a bug and we need to sort it out. We won't necessarily use all the information there in importing, but it shouldn't break the importer either.

The 0.9 is a reference to the latest version here (https://github.com/openlyrics/openlyrics), but it looks like nothing much has happened with it in the last 5 years or so.

ond1 commented 5 years ago

Hi,

Thanks for getting back to me. I did delete the sample file attachment. But you should be able to replicate it with the following XML document:

`<song xmlns="http://openlyrics.info/namespace/2009/song" version="0.8" createdIn="Song Stream 1.0" modifiedIn="OpenLyricsConverter.xsl" modifiedDate="2015-10-15T01:44:36.679+01:00">

Song1 TEST 2015 EAC song line 1

`

berry120 commented 5 years ago

Hmm, can't seem to reproduce it with that file on the CI release. Could you try at some point and let me know if you can (or I'm doing something wrong when trying to reproduce?)

ond1 commented 5 years ago

I think the problem occurs when there are several files in a zip. I will try to construct another zip file and post it.

chris-j-major commented 2 years ago

Hi @ond1 I was recently looking at the Open Lyrics importer, and so tested this on the latest version - and it successfully imported that xml file even when loaded via a zip file.

ond1 commented 2 years ago

Thanks @chris-j-major for looking into this. I have now converted all songs from the openLyrics XML format with my workaround. I have not tried it with the latest version of Quelea, but happy for you to close this bug issue.