quelea-projection / Quelea

Open source projection software for churches.
https://quelea.org
GNU General Public License v3.0
159 stars 145 forks source link

compareTo should check less than 0, not ==-1 #485

Closed berry120 closed 2 years ago

berry120 commented 2 years ago

The result of the compareTo() method should always use <0 0 or >0 to check the result - it shouldn't match any other value exactly (like -1.)

In UpdateCheck, line 54, that's exactly what we're doing though - it should instead check for <0.

JohnLennox commented 2 years ago

I would like to do this, Please assign to me

berry120 commented 2 years ago

All yours!