search

quelea-projection / Quelea

Open source projection software for churches.
https://quelea.org
GNU General Public License v3.0
159 stars 145 forks source link

Spelling of license #555

Closed Youngwily closed 2 years ago

Youngwily commented 2 years ago

Just a small issue, but in the UK the 'CCLI License' label displayed on slides should be spelt 'CCLI Licence'. In British English licence is a noun and license is a verb. Using license as a noun is a feature of American English. Would be great to have the option!

Youngwily commented 2 years ago

Is this a simple change I could make myself?

berry120 commented 2 years ago

Great spot! The issue here is that this particular string is hard coded and hasn't made it into our language label files (whoops.)

It's here (https://github.com/quelea-projection/Quelea/blob/b82e550e41d91a3ff4fbd9dbade61bd69275b698/Quelea/src/main/java/org/quelea/data/displayable/SongDisplayable.java#L852)

If you like you can make the change yourself - you'll need to add the required entry to the gb.lang file with a key of ccli.licence, and then change the hard-coded string to LabelGrabber.INSTANCE.getLabel("ccli.licence").

Youngwily commented 2 years ago

Hi Michael

Thank you for the email, only a small matter but I get a lot of comments from the older congregation!

I can find the gb.lang file and add a key to that

e.g.;

ccli.licence=CCLI Licence

however I can find the LabelGrabber.INSTANCE.getLabel("ccli.licence").

entry anywhere?

Thanks

Brian

From: Michael Berry @.> Sent: 07 September 2022 12:21 To: quelea-projection/Quelea @.> Cc: Youngwily @.>; Author @.> Subject: Re: [quelea-projection/Quelea] Spelling of license (Issue #555)

Great spot! The issue here is that this particular string is hard coded and hasn't made it into our language label files (whoops.)

It's here (https://github.com/quelea-projection/Quelea/blob/b82e550e41d91a3ff4fbd9dbade61bd69275b698/Quelea/src/main/java/org/quelea/data/displayable/SongDisplayable.java#L852)

If you like you can make the change yourself - you'll need to add the required entry to the gb.lang file with a key of ccli.licence, and then change the hard-coded string to LabelGrabber.INSTANCE.getLabel("ccli.licence").

— Reply to this email directly, view it on GitHub https://github.com/quelea-projection/Quelea/issues/555#issuecomment-1239259439 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AVKESJUYMZWWQ5WY3FW7AJLV5B3DLANCNFSM55UBSWEQ . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AVKESJVPW3POOUZSPFIGC5TV5B3DLA5CNFSM55UBSWE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJHOZSLY.gif Message ID: @. @.> >

berry120 commented 2 years ago

LabelGrabber.INSTANCE.getLabel("ccli.licence"). is just what you need to add in the code.

If you're not sure I'm happy to do it, just let me know 👍

Youngwily commented 2 years ago

Hi Michael Can you do it please, I don’t know in which file I need to insert that code. Brian

Get Outlook for iOShttps://aka.ms/o0ukef

From: Michael Berry @.> Sent: Friday, September 9, 2022 4:43:06 PM To: quelea-projection/Quelea @.> Cc: Youngwily @.>; Author @.> Subject: Re: [quelea-projection/Quelea] Spelling of license (Issue #555)

LabelGrabber.INSTANCE.getLabel("ccli.licence"). is just what you need to add in the code.

If you're not sure I'm happy to do it, just let me know 👍

— Reply to this email directly, view it on GitHubhttps://github.com/quelea-projection/Quelea/issues/555#issuecomment-1242140227, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVKESJQSSLV3ER4DE6ZN4H3V5NLIVANCNFSM55UBSWEQ. You are receiving this because you authored the thread.Message ID: @.***>

berry120 commented 2 years ago

All done!

Youngwily commented 2 years ago

Hi Michael is this change in the latest CI file? Brian

berry120 commented 2 years ago

Yes, it should be.

On Mon, 12 Sep 2022, 15:31 Youngwily, @.***> wrote:

Hi Michael is this change in the latest CI file? Brian

— Reply to this email directly, view it on GitHub https://github.com/quelea-projection/Quelea/issues/555#issuecomment-1243832195, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZ6JDJXGXX4HCK35AOW5XTV545FZANCNFSM55UBSWEQ . You are receiving this because you modified the open/close state.Message ID: @.***>

Youngwily commented 2 years ago

Hi Michael

Sorry to be a pest but the CI file wont install on my test platform (Win 10 Home, 64 bit) - when I rub the executable is says This app cant run on your PC.

If I run as administrator it cant find the file after asking if I want the file to make changes to my device. See attached screenshot

Any ideas?

Brian

From: Michael Berry @.> Sent: 12 September 2022 15:47 To: quelea-projection/Quelea @.> Cc: Youngwily @.>; Author @.> Subject: Re: [quelea-projection/Quelea] Spelling of license (Issue #555)

Yes, it should be.

On Mon, 12 Sep 2022, 15:31 Youngwily, @. <mailto:@.> > wrote:

Hi Michael is this change in the latest CI file? Brian

— Reply to this email directly, view it on GitHub

https://github.com/quelea-projection/Quelea/issues/555#issuecomment-1243832 195, or unsubscribe

https://github.com/notifications/unsubscribe-auth/ABZ6JDJXGXX4HCK35AOW5XTV5 45FZANCNFSM55UBSWEQ . You are receiving this because you modified the open/close state.Message ID: @. <mailto:@.> >

— Reply to this email directly, https://github.com/quelea-projection/Quelea/issues/555#issuecomment-1243853 597 view it on GitHub, or https://github.com/notifications/unsubscribe-auth/AVKESJW3DZJB25J2HEBRHKLV5 466RANCNFSM55UBSWEQ unsubscribe. You are receiving this because you authored the thread.Message ID: < @.> @.>

Youngwily commented 2 years ago

Sorry Michael ignore my last email, downloaded again and running ok

Brian

From: Michael Berry @.> Sent: 12 September 2022 15:47 To: quelea-projection/Quelea @.> Cc: Youngwily @.>; Author @.> Subject: Re: [quelea-projection/Quelea] Spelling of license (Issue #555)

Yes, it should be.

On Mon, 12 Sep 2022, 15:31 Youngwily, @. <mailto:@.> > wrote:

Hi Michael is this change in the latest CI file? Brian

— Reply to this email directly, view it on GitHub https://github.com/quelea-projection/Quelea/issues/555#issuecomment-1243832195, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZ6JDJXGXX4HCK35AOW5XTV545FZANCNFSM55UBSWEQ . You are receiving this because you modified the open/close state.Message ID: @. <mailto:@.> >

— Reply to this email directly, view it on GitHub https://github.com/quelea-projection/Quelea/issues/555#issuecomment-1243853597 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AVKESJW3DZJB25J2HEBRHKLV5466RANCNFSM55UBSWEQ . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AVKESJTC4JQKOP3IN2SSJX3V5466RA5CNFSM55UBSWE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJIR3GHI.gif Message ID: @. @.> >