Use Collection.addAll instead of loop

[berry120]

ImageGroupDisplayable.getResources() method uses a loop to add a bunch of File objects to a new ArrayList. Instead of this we could just use Collections.addAll().

[suhaas-livcd]

Hi @berry120 , I would like to work on this issue.

[Ashpreetwadhwa]

hey @berry120 i would like to do this task

[berry120]

@Ashpreetwadhwa Afraid this one is already assigned.

[Ashpreetwadhwa]

no problem @berry120

[suhaas-livcd]

@berry120

• I have check the issue, ImageGroupDisplayable.java
• I understand, we have to convert use Collections.addAll(f, files); instead of iterating over files and adding to list.
• My Doubts :
  1. As per the addAll(Collection) documentation, it returns boolean if the list is added. Should I LOG the return value too or just add Collections.addAll(f, files); ?
  2. Should I add function comments too with new method explanation ?

[berry120]

No need to log the value, and no need for any new comments as the functionality will be identical to the current implementation, just more concise.

[suhaas-livcd]

@berry120 Thank you for the information.

• Created the PR #583.
• Build check passed now, initially had problem with import statements, so was failing
• Request you to review my changes

[berry120]

Thanks!