search

quelea-projection / Quelea

Open source projection software for churches.
https://quelea.org
GNU General Public License v3.0
159 stars 145 forks source link

vscode IntelliCode analysis: 209 warnings - quality of source code could be enhanced? #603

Closed jbubik closed 1 year ago

jbubik commented 1 year ago

Hello devs, the IntelliCode analysis in Visual Studio Code shows various warnings for Quelea source code. Different kinds actually (unused variables, unused imports, unused fields, unused methods, dead code, resource leaks). I am a newbie into Java, so maybe I'm worried about something simple and harmless. Still it may help you somehow, so I post it here. I want to help, not be rude or offensive.

Below is a JSON array holding the results. I have no idea how to post it differently.

[{
"resource": "Quelea/src/main/java/org/quelea/data/bible/BibleSearchTreeView.java",
"code": "16777788",
"severity": 4,
"message": "ComboBox is a raw type. References to generic type ComboBox<T> should be parameterized",
"startLineNumber": 43,
"startColumn": 13,
"endLineNumber": 43,
"endColumn": 21
},{
"resource": "Quelea/src/main/java/org/quelea/data/bible/BibleSearchTreeView.java",
"code": "16777788",
"severity": 4,
"message": "ComboBox is a raw type. References to generic type ComboBox<T> should be parameterized",
"startLineNumber": 53,
"startColumn": 56,
"endLineNumber": 53,
"endColumn": 64
},{
"resource": "Quelea/src/main/java/org/quelea/data/displayable/AudioDisplayable.java",
"code": "16777547",
"severity": 4,
"message": "Redundant superinterface Serializable for the type AudioDisplayable, already defined by MultimediaDisplayable",
"startLineNumber": 19,
"startColumn": 65,
"endLineNumber": 19,
"endColumn": 77
},{
"resource": "Quelea/src/main/java/org/quelea/data/displayable/BiblePassage.java",
"code": "16777547",
"severity": 4,
"message": "Redundant superinterface Serializable for the type BiblePassage, already defined by TextDisplayable",
"startLineNumber": 52,
"startColumn": 55,
"endLineNumber": 52,
"endColumn": 67
},{
"resource": "Quelea/src/main/java/org/quelea/data/displayable/Displayable.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.scene.image.ImageView is never used",
"startLineNumber": 24,
"startColumn": 8,
"endLineNumber": 24,
"endColumn": 36,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/data/displayable/ImageGroupDisplayable.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field ImageGroupDisplayable.LOGGER is not used",
"startLineNumber": 45,
"startColumn": 33,
"endLineNumber": 45,
"endColumn": 39,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/data/displayable/SongDisplayable.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.scene.layout.BackgroundFill is never used",
"startLineNumber": 50,
"startColumn": 8,
"endLineNumber": 50,
"endColumn": 42,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/data/displayable/SongDisplayable.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.scene.layout.CornerRadii is never used",
"startLineNumber": 51,
"startColumn": 8,
"endLineNumber": 51,
"endColumn": 39,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/data/displayable/SongDisplayable.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.scene.paint.Color is never used",
"startLineNumber": 53,
"startColumn": 8,
"endLineNumber": 53,
"endColumn": 32,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/data/displayable/SongDisplayable.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.scene.text.Text is never used",
"startLineNumber": 54,
"startColumn": 8,
"endLineNumber": 54,
"endColumn": 30,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/data/displayable/SongDisplayable.java",
"code": "16777547",
"severity": 4,
"message": "Redundant superinterface Serializable for the type SongDisplayable, already defined by TextDisplayable",
"startLineNumber": 74,
"startColumn": 87,
"endLineNumber": 74,
"endColumn": 99
},{
"resource": "Quelea/src/main/java/org/quelea/data/displayable/TimerDisplayable.java",
"code": "16777547",
"severity": 4,
"message": "Redundant superinterface Serializable for the type TimerDisplayable, already defined by MultimediaDisplayable",
"startLineNumber": 51,
"startColumn": 65,
"endLineNumber": 51,
"endColumn": 77
},{
"resource": "Quelea/src/main/java/org/quelea/data/displayable/TimerDisplayable.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field TimerDisplayable.background is not used",
"startLineNumber": 53,
"startColumn": 30,
"endLineNumber": 53,
"endColumn": 40,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/data/displayable/VideoDisplayable.java",
"code": "16777547",
"severity": 4,
"message": "Redundant superinterface Serializable for the type VideoDisplayable, already defined by MultimediaDisplayable",
"startLineNumber": 41,
"startColumn": 65,
"endLineNumber": 41,
"endColumn": 77
},{
"resource": "Quelea/src/main/java/org/quelea/data/powerpoint/OOPresentation.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable p is not used",
"startLineNumber": 433,
"startColumn": 33,
"endLineNumber": 433,
"endColumn": 34,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/data/powerpoint/PPTPresentation.java",
"code": "268435844",
"severity": 4,
"message": "The import java.io.File is never used",
"startLineNumber": 20,
"startColumn": 8,
"endLineNumber": 20,
"endColumn": 20,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/data/powerpoint/PPTPresentation.java",
"code": "268435844",
"severity": 4,
"message": "The import org.apache.poi.xslf.usermodel.XMLSlideShow is never used",
"startLineNumber": 26,
"startColumn": 8,
"endLineNumber": 26,
"endColumn": 50,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/data/powerpoint/PPTXPresentation.java",
"code": "268435844",
"severity": 4,
"message": "The import java.io.File is never used",
"startLineNumber": 20,
"startColumn": 8,
"endLineNumber": 20,
"endColumn": 20,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/data/powerpoint/PresentationSlide.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field PresentationSlide.WIDTH is not used",
"startLineNumber": 48,
"startColumn": 30,
"endLineNumber": 48,
"endColumn": 35,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/data/powerpoint/PresentationSlide.java",
"code": "16777788",
"severity": 4,
"message": "Slide is a raw type. References to generic type Slide<S,P> should be parameterized",
"startLineNumber": 58,
"startColumn": 30,
"endLineNumber": 58,
"endColumn": 35
},{
"resource": "Quelea/src/main/java/org/quelea/data/powerpoint/PresentationSlide.java",
"code": "16777788",
"severity": 4,
"message": "SlideShow is a raw type. References to generic type SlideShow<S,P> should be parameterized",
"startLineNumber": 59,
"startColumn": 9,
"endLineNumber": 59,
"endColumn": 18
},{
"resource": "Quelea/src/main/java/org/quelea/server/RCHandler.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable p is not used",
"startLineNumber": 451,
"startColumn": 29,
"endLineNumber": 451,
"endColumn": 30,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/server/RemoteControlServer.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field RemoteControlServer.ThemeThumbnailsHandler.fileNameMap is not used",
"startLineNumber": 311,
"startColumn": 21,
"endLineNumber": 311,
"endColumn": 32,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/ElevantoImportDialog.java",
"code": "16777788",
"severity": 4,
"message": "TreeView is a raw type. References to generic type TreeView<T> should be parameterized",
"startLineNumber": 62,
"startColumn": 19,
"endLineNumber": 62,
"endColumn": 27
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/ElevantoImportDialog.java",
"code": "536871547",
"severity": 4,
"message": "Unnecessary @SuppressWarnings(\"unchecked\")",
"startLineNumber": 174,
"startColumn": 27,
"endLineNumber": 174,
"endColumn": 38,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/ElevantoImportDialog.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable serviceTypeId is not used",
"startLineNumber": 181,
"startColumn": 24,
"endLineNumber": 181,
"endColumn": 37,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/ElevantoLoginDialog.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable contentType is not used",
"startLineNumber": 102,
"startColumn": 20,
"endLineNumber": 102,
"endColumn": 31,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/ElevantoLoginDialog.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable refreshToken is not used",
"startLineNumber": 134,
"startColumn": 24,
"endLineNumber": 134,
"endColumn": 36,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/ElevantoLoginDialog.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable expiresIn is not used",
"startLineNumber": 135,
"startColumn": 21,
"endLineNumber": 135,
"endColumn": 30,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/ElevantoLoginDialog.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable error is not used",
"startLineNumber": 143,
"startColumn": 24,
"endLineNumber": 143,
"endColumn": 29,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/ElevantoLoginDialog.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable context is not used",
"startLineNumber": 176,
"startColumn": 25,
"endLineNumber": 176,
"endColumn": 32,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/ElevantoPlanDialog.java",
"code": "16777788",
"severity": 4,
"message": "TreeView is a raw type. References to generic type TreeView<T> should be parameterized",
"startLineNumber": 77,
"startColumn": 19,
"endLineNumber": 77,
"endColumn": 27
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/ElevantoPlanDialog.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable song is not used",
"startLineNumber": 110,
"startColumn": 24,
"endLineNumber": 110,
"endColumn": 28,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/ElevantoPlanDialog.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable groupCount is not used",
"startLineNumber": 363,
"startColumn": 21,
"endLineNumber": 363,
"endColumn": 31,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/EpicWorshipParser.java",
"code": "536871799",
"severity": 4,
"message": "Resource leak: 'bfr' is never closed",
"startLineNumber": 47,
"startColumn": 24,
"endLineNumber": 47,
"endColumn": 27
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/MediaShoutParser.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable playorder is not used",
"startLineNumber": 51,
"startColumn": 20,
"endLineNumber": 51,
"endColumn": 29,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/PDFExporter.java",
"code": "536871061",
"severity": 4,
"message": "Dead code",
"startLineNumber": 133,
"startColumn": 31,
"endLineNumber": 133,
"endColumn": 84
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/PlanningCenterOnlineImportDialog.java",
"code": "268435844",
"severity": 4,
"message": "The import java.util.Collections is never used",
"startLineNumber": 23,
"startColumn": 8,
"endLineNumber": 23,
"endColumn": 29,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/PlanningCenterOnlineImportDialog.java",
"code": "268435844",
"severity": 4,
"message": "The import java.util.Comparator is never used",
"startLineNumber": 24,
"startColumn": 8,
"endLineNumber": 24,
"endColumn": 28,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/PlanningCenterOnlineImportDialog.java",
"code": "16777788",
"severity": 4,
"message": "TreeView is a raw type. References to generic type TreeView<T> should be parameterized",
"startLineNumber": 70,
"startColumn": 13,
"endLineNumber": 70,
"endColumn": 21
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/PlanningCenterOnlineImportDialog.java",
"code": "536871547",
"severity": 4,
"message": "Unnecessary @SuppressWarnings(\"unchecked\")",
"startLineNumber": 185,
"startColumn": 27,
"endLineNumber": 185,
"endColumn": 38,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/PlanningCenterOnlinePlanDialog.java",
"code": "536871547",
"severity": 4,
"message": "Unnecessary @SuppressWarnings(\"unchecked\")",
"startLineNumber": 143,
"startColumn": 23,
"endLineNumber": 143,
"endColumn": 34,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/PlanningCenterOnlinePlanDialog.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable groupCount is not used",
"startLineNumber": 474,
"startColumn": 21,
"endLineNumber": 474,
"endColumn": 31,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/ProPresenterParser.java",
"code": "268435844",
"severity": 4,
"message": "The import java.util.HashMap is never used",
"startLineNumber": 46,
"startColumn": 8,
"endLineNumber": 46,
"endColumn": 25,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/ScreenMonkeyParser.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable tempo is not used",
"startLineNumber": 72,
"startColumn": 20,
"endLineNumber": 72,
"endColumn": 25,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/ScreenMonkeyParser.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable timesig is not used",
"startLineNumber": 73,
"startColumn": 20,
"endLineNumber": 73,
"endColumn": 27,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/ScreenMonkeyParser.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable theme is not used",
"startLineNumber": 75,
"startColumn": 20,
"endLineNumber": 75,
"endColumn": 25,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/ScreenMonkeyParser.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable comments is not used",
"startLineNumber": 76,
"startColumn": 20,
"endLineNumber": 76,
"endColumn": 28,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/SoFParser.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field SoFParser.LOGGER is not used",
"startLineNumber": 46,
"startColumn": 33,
"endLineNumber": 46,
"endColumn": 39,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/SongBeamerParser.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field SongBeamerParser.LOGGER is not used",
"startLineNumber": 45,
"startColumn": 33,
"endLineNumber": 45,
"endColumn": 39,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/SongBeamerParser.java",
"code": "536871799",
"severity": 4,
"message": "Resource leak: 'reader' is never closed",
"startLineNumber": 58,
"startColumn": 24,
"endLineNumber": 58,
"endColumn": 30
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/SongProParser.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field SongProParser.LOGGER is not used",
"startLineNumber": 43,
"startColumn": 33,
"endLineNumber": 43,
"endColumn": 39,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/importexport/VideoPsalmParser.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field VideoPsalmParser.LOGGER is not used",
"startLineNumber": 39,
"startColumn": 30,
"endLineNumber": 39,
"endColumn": 36,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/print/PDFPrinter.java",
"code": "536871547",
"severity": 4,
"message": "Unnecessary @SuppressWarnings(\"unchecked\")",
"startLineNumber": 65,
"startColumn": 23,
"endLineNumber": 65,
"endColumn": 34,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/utils/LineTypeChecker.java",
"code": "268435844",
"severity": 4,
"message": "The import java.util.Comparator is never used",
"startLineNumber": 20,
"startColumn": 8,
"endLineNumber": 20,
"endColumn": 28,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/utils/ReleaseSummaryGenerator.java",
"code": "33555193",
"severity": 4,
"message": "The enum constant RELEASE needs a corresponding case label in this enum switch on VersionType",
"startLineNumber": 51,
"startColumn": 17,
"endLineNumber": 51,
"endColumn": 59
},{
"resource": "Quelea/src/main/java/org/quelea/services/utils/SerializableFont.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field SerializableFont.name is not used",
"startLineNumber": 34,
"startColumn": 20,
"endLineNumber": 34,
"endColumn": 24,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/services/utils/Utils.java",
"code": "536871799",
"severity": 4,
"message": "Resource leak: '<unassigned Closeable value>' is never closed",
"startLineNumber": 644,
"startColumn": 13,
"endLineNumber": 644,
"endColumn": 44
},{
"resource": "Quelea/src/main/java/org/quelea/services/utils/Utils.java",
"code": "536871799",
"severity": 4,
"message": "Resource leak: '<unassigned Closeable value>' is never closed",
"startLineNumber": 645,
"startColumn": 18,
"endLineNumber": 645,
"endColumn": 48
},{
"resource": "Quelea/src/main/java/org/quelea/services/utils/Utils.java",
"code": "536871799",
"severity": 4,
"message": "Resource leak: 'zipFile' is never closed",
"startLineNumber": 1092,
"startColumn": 5,
"endLineNumber": 1092,
"endColumn": 31
},{
"resource": "Quelea/src/main/java/org/quelea/services/utils/Utils.java",
"code": "16777788",
"severity": 4,
"message": "Enumeration is a raw type. References to generic type Enumeration<E> should be parameterized",
"startLineNumber": 1100,
"startColumn": 4,
"endLineNumber": 1100,
"endColumn": 15
},{
"resource": "Quelea/src/main/java/org/quelea/utils/BigDecimalSpinner.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.event.ActionEvent is never used",
"startLineNumber": 25,
"startColumn": 8,
"endLineNumber": 25,
"endColumn": 32,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/utils/BigDecimalSpinner.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.event.EventHandler is never used",
"startLineNumber": 26,
"startColumn": 8,
"endLineNumber": 26,
"endColumn": 33,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/utils/BigDecimalSpinner.java",
"code": "268435844",
"severity": 4,
"message": "The import org.quelea.utils.BigDecimalTextField is never used",
"startLineNumber": 37,
"startColumn": 8,
"endLineNumber": 37,
"endColumn": 44,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/utils/BigDecimalTextField.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.beans.value.ChangeListener is never used",
"startLineNumber": 25,
"startColumn": 8,
"endLineNumber": 25,
"endColumn": 41,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/utils/BigDecimalTextField.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.beans.value.ObservableValue is never used",
"startLineNumber": 26,
"startColumn": 8,
"endLineNumber": 26,
"endColumn": 42,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/utils/BigDecimalTextField.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.event.ActionEvent is never used",
"startLineNumber": 27,
"startColumn": 8,
"endLineNumber": 27,
"endColumn": 32,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/utils/BigDecimalTextField.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.event.EventHandler is never used",
"startLineNumber": 28,
"startColumn": 8,
"endLineNumber": 28,
"endColumn": 33,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/utils/OpenLyricsWriter.java",
"code": "268435844",
"severity": 4,
"message": "The import javax.xml.transform.TransformerConfigurationException is never used",
"startLineNumber": 48,
"startColumn": 8,
"endLineNumber": 48,
"endColumn": 61,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/utils/OpenLyricsWriter.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable result is not used",
"startLineNumber": 119,
"startColumn": 22,
"endLineNumber": 119,
"endColumn": 28,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/utils/PlatformUtils.java",
"code": "536871061",
"severity": 4,
"message": "Dead code",
"startLineNumber": 67,
"startColumn": 9,
"endLineNumber": 67,
"endColumn": 30
},{
"resource": "Quelea/src/main/java/org/quelea/windows/help/AboutDialog.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field AboutDialog.LOGGER is not used",
"startLineNumber": 56,
"startColumn": 33,
"endLineNumber": 56,
"endColumn": 39,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/imagegroup/ImageGroupPanel.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.beans.value.ChangeListener is never used",
"startLineNumber": 24,
"startColumn": 8,
"endLineNumber": 24,
"endColumn": 41,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/imagegroup/ImageGroupPanel.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.beans.value.ObservableValue is never used",
"startLineNumber": 25,
"startColumn": 8,
"endLineNumber": 25,
"endColumn": 42,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/imagegroup/ImageGroupPanel.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.event.ActionEvent is never used",
"startLineNumber": 26,
"startColumn": 8,
"endLineNumber": 26,
"endColumn": 32,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/imagegroup/ImageGroupPanel.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.event.EventHandler is never used",
"startLineNumber": 27,
"startColumn": 8,
"endLineNumber": 27,
"endColumn": 33,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/imagegroup/ImageGroupPanel.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable lp is not used",
"startLineNumber": 69,
"startColumn": 27,
"endLineNumber": 69,
"endColumn": 29,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/library/DisplayableListCell.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.beans.value.ChangeListener is never used",
"startLineNumber": 21,
"startColumn": 8,
"endLineNumber": 21,
"endColumn": 41,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/library/DisplayableListCell.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.beans.value.ObservableValue is never used",
"startLineNumber": 22,
"startColumn": 8,
"endLineNumber": 22,
"endColumn": 42,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/library/LibraryBiblePanel.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable passages is not used",
"startLineNumber": 274,
"startColumn": 33,
"endLineNumber": 274,
"endColumn": 41,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/library/TimerListPanel.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field TimerListPanel.BORDER_STYLE_SELECTED is not used",
"startLineNumber": 58,
"startColumn": 33,
"endLineNumber": 58,
"endColumn": 54,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/library/TimerListPanel.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field TimerListPanel.BORDER_STYLE_DESELECTED is not used",
"startLineNumber": 59,
"startColumn": 33,
"endLineNumber": 59,
"endColumn": 56,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/lyrics/LyricDrawer.java",
"code": "268435844",
"severity": 4,
"message": "The import java.util.Iterator is never used",
"startLineNumber": 24,
"startColumn": 8,
"endLineNumber": 24,
"endColumn": 26,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/lyrics/SelectLyricsPanel.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field SelectLyricsPanel.LOGGER is not used",
"startLineNumber": 48,
"startColumn": 33,
"endLineNumber": 48,
"endColumn": 39,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/lyrics/TranslationChoiceDialog.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field TranslationChoiceDialog.currentSong is not used",
"startLineNumber": 50,
"startColumn": 29,
"endLineNumber": 50,
"endColumn": 40,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/AbstractPanel.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field AbstractPanel.LOGGER is not used",
"startLineNumber": 45,
"startColumn": 33,
"endLineNumber": 45,
"endColumn": 39,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/actionhandlers/ExportPDFScheduleActionHandler.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable path is not used",
"startLineNumber": 61,
"startColumn": 24,
"endLineNumber": 61,
"endColumn": 28,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/actionhandlers/ExportPDFScheduleSongsActionHandler.java",
"code": "268435844",
"severity": 4,
"message": "The import java.util.HashSet is never used",
"startLineNumber": 26,
"startColumn": 8,
"endLineNumber": 26,
"endColumn": 25,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/actionhandlers/ExportPDFScheduleSongsActionHandler.java",
"code": "268435844",
"severity": 4,
"message": "The import org.quelea.services.utils.Utils is never used",
"startLineNumber": 43,
"startColumn": 8,
"endLineNumber": 43,
"endColumn": 39,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/actionhandlers/RecordingsHandler.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable vlcProcess is not used",
"startLineNumber": 325,
"startColumn": 17,
"endLineNumber": 325,
"endColumn": 27,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/DisplayCanvas.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.beans.value.ChangeListener is never used",
"startLineNumber": 25,
"startColumn": 8,
"endLineNumber": 25,
"endColumn": 41,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/DisplayCanvas.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.beans.value.ObservableValue is never used",
"startLineNumber": 26,
"startColumn": 8,
"endLineNumber": 26,
"endColumn": 42,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/DisplayStage.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.beans.value.ObservableValue is never used",
"startLineNumber": 22,
"startColumn": 8,
"endLineNumber": 22,
"endColumn": 42,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/DisplayStage.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field DisplayStage.LOGGER is not used",
"startLineNumber": 47,
"startColumn": 33,
"endLineNumber": 47,
"endColumn": 39,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/Main.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable img is not used",
"startLineNumber": 91,
"startColumn": 23,
"endLineNumber": 91,
"endColumn": 26,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/menus/FileMenu.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable darkTheme is not used",
"startLineNumber": 59,
"startColumn": 17,
"endLineNumber": 59,
"endColumn": 26,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/menus/HelpMenu.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field HelpMenu.LOGGER is not used",
"startLineNumber": 43,
"startColumn": 33,
"endLineNumber": 43,
"endColumn": 39,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/menus/HelpMenu.java",
"code": "603979894",
"severity": 4,
"message": "The method showError(String) from the type HelpMenu is never used locally",
"startLineNumber": 103,
"startColumn": 18,
"endLineNumber": 103,
"endColumn": 40,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/menus/ScheduleMenu.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field ScheduleMenu.LOGGER is not used",
"startLineNumber": 54,
"startColumn": 33,
"endLineNumber": 54,
"endColumn": 39,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/menus/ScheduleMenu.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable scheduleList is not used",
"startLineNumber": 73,
"startColumn": 28,
"endLineNumber": 73,
"endColumn": 40,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/QueleaApp.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field QueleaApp.ads is not used",
"startLineNumber": 43,
"startColumn": 30,
"endLineNumber": 43,
"endColumn": 33,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/quickedit/QuickEditDialog.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.stage.Modality is never used",
"startLineNumber": 33,
"startColumn": 8,
"endLineNumber": 33,
"endColumn": 29,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/quickedit/QuickEditDialog.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.stage.StageStyle is never used",
"startLineNumber": 35,
"startColumn": 8,
"endLineNumber": 35,
"endColumn": 31,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/schedule/SchedulePanel.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field SchedulePanel.LOGGER is not used",
"startLineNumber": 60,
"startColumn": 33,
"endLineNumber": 60,
"endColumn": 39,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/ThemePreviewPanel.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field ThemePreviewPanel.popup is not used",
"startLineNumber": 71,
"startColumn": 20,
"endLineNumber": 71,
"endColumn": 25,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/ThemePreviewPanel.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field ThemePreviewPanel.parent is not used",
"startLineNumber": 72,
"startColumn": 31,
"endLineNumber": 72,
"endColumn": 37,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/toolbars/MainToolbar.java",
"code": "603979894",
"severity": 4,
"message": "The method getButtonFromImage(String, int, int, boolean, boolean) from the type MainToolbar is never used locally",
"startLineNumber": 345,
"startColumn": 20,
"endLineNumber": 345,
"endColumn": 112,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/widgets/BooleanCell.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.beans.value.ChangeListener is never used",
"startLineNumber": 21,
"startColumn": 8,
"endLineNumber": 21,
"endColumn": 41,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/widgets/BooleanCell.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.beans.value.ObservableValue is never used",
"startLineNumber": 22,
"startColumn": 8,
"endLineNumber": 22,
"endColumn": 42,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/widgets/DisplayPositionSelector.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.event.ActionEvent is never used",
"startLineNumber": 23,
"startColumn": 8,
"endLineNumber": 23,
"endColumn": 32,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/widgets/DisplayPositionSelector.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.event.EventHandler is never used",
"startLineNumber": 24,
"startColumn": 8,
"endLineNumber": 24,
"endColumn": 33,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/widgets/DisplayPositionSelector.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.scene.input.MouseEvent is never used",
"startLineNumber": 28,
"startColumn": 8,
"endLineNumber": 28,
"endColumn": 37,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/main/widgets/DisplayPreview.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.beans.value.ObservableValue is never used",
"startLineNumber": 21,
"startColumn": 8,
"endLineNumber": 21,
"endColumn": 42,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/multimedia/MacVideo.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field MacVideo.MAC_VID_EXECUTOR is not used",
"startLineNumber": 41,
"startColumn": 42,
"endLineNumber": 41,
"endColumn": 58,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/multimedia/VLCWindowDirect.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field VLCWindowDirect.broderPane is not used",
"startLineNumber": 89,
"startColumn": 24,
"endLineNumber": 89,
"endColumn": 34,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/multimedia/VLCWindowDirect.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field VLCWindowDirect.intBuffer is not used",
"startLineNumber": 92,
"startColumn": 19,
"endLineNumber": 92,
"endColumn": 28,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/multimedia/VLCWindowDirect.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field VLCWindowDirect.bufferFormat is not used",
"startLineNumber": 93,
"startColumn": 26,
"endLineNumber": 93,
"endColumn": 38,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/multimedia/VLCWindowDirect.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field VLCWindowDirect.canvasScaled is not used",
"startLineNumber": 94,
"startColumn": 21,
"endLineNumber": 94,
"endColumn": 33,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/multimedia/VLCWindowDirect.java",
"code": "603979894",
"severity": 4,
"message": "The method scaleCanvas() from the type VLCWindowDirect is never used locally",
"startLineNumber": 251,
"startColumn": 21,
"endLineNumber": 251,
"endColumn": 34,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/multimedia/VLCWindowEmbed.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field VLCWindowEmbed.disposeFrame is not used",
"startLineNumber": 88,
"startColumn": 21,
"endLineNumber": 88,
"endColumn": 33,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/newsong/BasicSongPanel.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.beans.value.ChangeListener is never used",
"startLineNumber": 22,
"startColumn": 8,
"endLineNumber": 22,
"endColumn": 41,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/newsong/BasicSongPanel.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.beans.value.ObservableValue is never used",
"startLineNumber": 23,
"startColumn": 8,
"endLineNumber": 23,
"endColumn": 42,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/newsong/BasicSongPanel.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.event.EventHandler is never used",
"startLineNumber": 25,
"startColumn": 8,
"endLineNumber": 25,
"endColumn": 33,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/newsong/BasicSongPanel.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field BasicSongPanel.LOGGER is not used",
"startLineNumber": 70,
"startColumn": 33,
"endLineNumber": 70,
"endColumn": 39,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/newsong/FontOptionsDialog.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.beans.value.ChangeListener is never used",
"startLineNumber": 23,
"startColumn": 8,
"endLineNumber": 23,
"endColumn": 41,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/newsong/FontOptionsDialog.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.beans.value.ObservableValue is never used",
"startLineNumber": 24,
"startColumn": 8,
"endLineNumber": 24,
"endColumn": 42,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/newsong/FontOptionsDialog.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.event.EventHandler is never used",
"startLineNumber": 26,
"startColumn": 8,
"endLineNumber": 26,
"endColumn": 33,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/newsong/ImageButton.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.event.EventHandler is never used",
"startLineNumber": 24,
"startColumn": 8,
"endLineNumber": 24,
"endColumn": 33,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/newsong/SongEntryWindow.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.stage.WindowEvent is never used",
"startLineNumber": 38,
"startColumn": 8,
"endLineNumber": 38,
"endColumn": 32,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/newsong/ThemeToolbar.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field ThemeToolbar.LOGGER is not used",
"startLineNumber": 75,
"startColumn": 33,
"endLineNumber": 75,
"endColumn": 39,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/newsong/VideoButton.java",
"code": "536871799",
"severity": 4,
"message": "Resource leak: '<unassigned Closeable value>' is never closed",
"startLineNumber": 135,
"startColumn": 32,
"endLineNumber": 135,
"endColumn": 55
},{
"resource": "Quelea/src/main/java/org/quelea/windows/newsong/VideoButton.java",
"code": "536871799",
"severity": 4,
"message": "Resource leak: '<unassigned Closeable value>' is never closed",
"startLineNumber": 136,
"startColumn": 36,
"endLineNumber": 136,
"endColumn": 61
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/customprefs/DefaultBibleSelector.java",
"code": "16777748",
"severity": 4,
"message": "Type safety: The expression of type ObservableList needs unchecked conversion to conform to ObservableList<String>",
"startLineNumber": 57,
"startColumn": 41,
"endLineNumber": 57,
"endColumn": 57
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/customprefs/DefaultBibleSelector.java",
"code": "16777748",
"severity": 4,
"message": "Type safety: The expression of type ObservableList needs unchecked conversion to conform to ObservableList<String>",
"startLineNumber": 97,
"startColumn": 71,
"endLineNumber": 97,
"endColumn": 87
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/DisplayGroup.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 44,
"startColumn": 60,
"endLineNumber": 44,
"endColumn": 65
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/DisplayGroup.java",
"code": "16777788",
"severity": 4,
"message": "ObservableValue is a raw type. References to generic type ObservableValue<T> should be parameterized",
"startLineNumber": 44,
"startColumn": 67,
"endLineNumber": 44,
"endColumn": 82
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/DisplayGroup.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 58,
"startColumn": 9,
"endLineNumber": 58,
"endColumn": 14
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/DisplayGroup.java",
"code": "16777786",
"severity": 4,
"message": "Type safety: Unchecked invocation of(String, Field, ObjectProperty<String>) of the generic method of(String, F, P) of type Setting",
"startLineNumber": 74,
"startColumn": 21,
"endLineNumber": 74,
"endColumn": 79
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/DisplayGroup.java",
"code": "16777786",
"severity": 4,
"message": "Type safety: Unchecked invocation of(String, Field, ObjectProperty<String>) of the generic method of(String, F, P) of type Setting",
"startLineNumber": 122,
"startColumn": 21,
"endLineNumber": 122,
"endColumn": 79
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsBiblePanel.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 46,
"startColumn": 21,
"endLineNumber": 46,
"endColumn": 26
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsBiblePanel.java",
"code": "16777788",
"severity": 4,
"message": "ObservableValue is a raw type. References to generic type ObservableValue<T> should be parameterized",
"startLineNumber": 46,
"startColumn": 28,
"endLineNumber": 46,
"endColumn": 43
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsBiblePanel.java",
"code": "16777788",
"severity": 4,
"message": "Setting is a raw type. References to generic type Setting<E,P> should be parameterized",
"startLineNumber": 47,
"startColumn": 13,
"endLineNumber": 47,
"endColumn": 20
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsBiblePanel.java",
"code": "16777788",
"severity": 4,
"message": "Setting is a raw type. References to generic type Setting<E,P> should be parameterized",
"startLineNumber": 48,
"startColumn": 13,
"endLineNumber": 48,
"endColumn": 20
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsBiblePanel.java",
"code": "16777788",
"severity": 4,
"message": "Setting is a raw type. References to generic type Setting<E,P> should be parameterized",
"startLineNumber": 50,
"startColumn": 13,
"endLineNumber": 50,
"endColumn": 20
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsBiblePanel.java",
"code": "16777788",
"severity": 4,
"message": "Setting is a raw type. References to generic type Setting<E,P> should be parameterized",
"startLineNumber": 52,
"startColumn": 13,
"endLineNumber": 52,
"endColumn": 20
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsBiblePanel.java",
"code": "16777788",
"severity": 4,
"message": "Setting is a raw type. References to generic type Setting<E,P> should be parameterized",
"startLineNumber": 54,
"startColumn": 13,
"endLineNumber": 54,
"endColumn": 20
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsBiblePanel.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 62,
"startColumn": 31,
"endLineNumber": 62,
"endColumn": 36
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsBiblePanel.java",
"code": "16777788",
"severity": 4,
"message": "ObservableValue is a raw type. References to generic type ObservableValue<T> should be parameterized",
"startLineNumber": 62,
"startColumn": 38,
"endLineNumber": 62,
"endColumn": 53
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsBiblePanel.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 93,
"startColumn": 23,
"endLineNumber": 93,
"endColumn": 28
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsDisplaySetupPanel.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 37,
"startColumn": 21,
"endLineNumber": 37,
"endColumn": 26
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsDisplaySetupPanel.java",
"code": "16777788",
"severity": 4,
"message": "ObservableValue is a raw type. References to generic type ObservableValue<T> should be parameterized",
"startLineNumber": 37,
"startColumn": 28,
"endLineNumber": 37,
"endColumn": 43
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsDisplaySetupPanel.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field OptionsDisplaySetupPanel.bindings is not used",
"startLineNumber": 37,
"startColumn": 45,
"endLineNumber": 37,
"endColumn": 53,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsDisplaySetupPanel.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 47,
"startColumn": 38,
"endLineNumber": 47,
"endColumn": 43
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsDisplaySetupPanel.java",
"code": "16777788",
"severity": 4,
"message": "ObservableValue is a raw type. References to generic type ObservableValue<T> should be parameterized",
"startLineNumber": 47,
"startColumn": 45,
"endLineNumber": 47,
"endColumn": 60
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsGeneralPanel.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 68,
"startColumn": 21,
"endLineNumber": 68,
"endColumn": 26
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsGeneralPanel.java",
"code": "16777788",
"severity": 4,
"message": "ObservableValue is a raw type. References to generic type ObservableValue<T> should be parameterized",
"startLineNumber": 68,
"startColumn": 28,
"endLineNumber": 68,
"endColumn": 43
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsGeneralPanel.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 79,
"startColumn": 33,
"endLineNumber": 79,
"endColumn": 38
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsGeneralPanel.java",
"code": "16777788",
"severity": 4,
"message": "ObservableValue is a raw type. References to generic type ObservableValue<T> should be parameterized",
"startLineNumber": 79,
"startColumn": 40,
"endLineNumber": 79,
"endColumn": 55
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsImportExportPanel.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 45,
"startColumn": 21,
"endLineNumber": 45,
"endColumn": 26
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsImportExportPanel.java",
"code": "16777788",
"severity": 4,
"message": "ObservableValue is a raw type. References to generic type ObservableValue<T> should be parameterized",
"startLineNumber": 45,
"startColumn": 28,
"endLineNumber": 45,
"endColumn": 43
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsImportExportPanel.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field OptionsImportExportPanel.bindings is not used",
"startLineNumber": 45,
"startColumn": 45,
"endLineNumber": 45,
"endColumn": 53,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsImportExportPanel.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 54,
"startColumn": 38,
"endLineNumber": 54,
"endColumn": 43
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsImportExportPanel.java",
"code": "16777788",
"severity": 4,
"message": "ObservableValue is a raw type. References to generic type ObservableValue<T> should be parameterized",
"startLineNumber": 54,
"startColumn": 45,
"endLineNumber": 54,
"endColumn": 60
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsNoticePanel.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 45,
"startColumn": 21,
"endLineNumber": 45,
"endColumn": 26
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsNoticePanel.java",
"code": "16777788",
"severity": 4,
"message": "ObservableValue is a raw type. References to generic type ObservableValue<T> should be parameterized",
"startLineNumber": 45,
"startColumn": 28,
"endLineNumber": 45,
"endColumn": 43
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsNoticePanel.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 54,
"startColumn": 32,
"endLineNumber": 54,
"endColumn": 37
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsNoticePanel.java",
"code": "16777788",
"severity": 4,
"message": "ObservableValue is a raw type. References to generic type ObservableValue<T> should be parameterized",
"startLineNumber": 54,
"startColumn": 39,
"endLineNumber": 54,
"endColumn": 54
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsPresentationPanel.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 48,
"startColumn": 21,
"endLineNumber": 48,
"endColumn": 26
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsPresentationPanel.java",
"code": "16777788",
"severity": 4,
"message": "ObservableValue is a raw type. References to generic type ObservableValue<T> should be parameterized",
"startLineNumber": 48,
"startColumn": 28,
"endLineNumber": 48,
"endColumn": 43
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsPresentationPanel.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 59,
"startColumn": 38,
"endLineNumber": 59,
"endColumn": 43
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsPresentationPanel.java",
"code": "16777788",
"severity": 4,
"message": "ObservableValue is a raw type. References to generic type ObservableValue<T> should be parameterized",
"startLineNumber": 59,
"startColumn": 45,
"endLineNumber": 59,
"endColumn": 60
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsRecordingPanel.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 47,
"startColumn": 21,
"endLineNumber": 47,
"endColumn": 26
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsRecordingPanel.java",
"code": "16777788",
"severity": 4,
"message": "ObservableValue is a raw type. References to generic type ObservableValue<T> should be parameterized",
"startLineNumber": 47,
"startColumn": 28,
"endLineNumber": 47,
"endColumn": 43
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsRecordingPanel.java",
"code": "16777788",
"severity": 4,
"message": "Setting is a raw type. References to generic type Setting<E,P> should be parameterized",
"startLineNumber": 51,
"startColumn": 13,
"endLineNumber": 51,
"endColumn": 20
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsRecordingPanel.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 60,
"startColumn": 35,
"endLineNumber": 60,
"endColumn": 40
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsRecordingPanel.java",
"code": "16777788",
"severity": 4,
"message": "ObservableValue is a raw type. References to generic type ObservableValue<T> should be parameterized",
"startLineNumber": 60,
"startColumn": 42,
"endLineNumber": 60,
"endColumn": 57
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsRecordingPanel.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 72,
"startColumn": 23,
"endLineNumber": 72,
"endColumn": 28
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsServerSettingsPanel.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 52,
"startColumn": 21,
"endLineNumber": 52,
"endColumn": 26
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsServerSettingsPanel.java",
"code": "16777788",
"severity": 4,
"message": "ObservableValue is a raw type. References to generic type ObservableValue<T> should be parameterized",
"startLineNumber": 52,
"startColumn": 28,
"endLineNumber": 52,
"endColumn": 43
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsServerSettingsPanel.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field OptionsServerSettingsPanel.bindings is not used",
"startLineNumber": 52,
"startColumn": 45,
"endLineNumber": 52,
"endColumn": 53,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsServerSettingsPanel.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 68,
"startColumn": 40,
"endLineNumber": 68,
"endColumn": 45
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsServerSettingsPanel.java",
"code": "16777788",
"severity": 4,
"message": "ObservableValue is a raw type. References to generic type ObservableValue<T> should be parameterized",
"startLineNumber": 68,
"startColumn": 47,
"endLineNumber": 68,
"endColumn": 62
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsStageViewPanel.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 49,
"startColumn": 21,
"endLineNumber": 49,
"endColumn": 26
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsStageViewPanel.java",
"code": "16777788",
"severity": 4,
"message": "ObservableValue is a raw type. References to generic type ObservableValue<T> should be parameterized",
"startLineNumber": 49,
"startColumn": 28,
"endLineNumber": 49,
"endColumn": 43
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsStageViewPanel.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field OptionsStageViewPanel.bindings is not used",
"startLineNumber": 49,
"startColumn": 45,
"endLineNumber": 49,
"endColumn": 53,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsStageViewPanel.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 60,
"startColumn": 35,
"endLineNumber": 60,
"endColumn": 40
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/OptionsStageViewPanel.java",
"code": "16777788",
"severity": 4,
"message": "ObservableValue is a raw type. References to generic type ObservableValue<T> should be parameterized",
"startLineNumber": 60,
"startColumn": 42,
"endLineNumber": 60,
"endColumn": 57
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/PreferencesDialog.java",
"code": "268435844",
"severity": 4,
"message": "The import com.dlsc.preferencesfx.formsfx.view.controls.SimpleComboBoxControl is never used",
"startLineNumber": 23,
"startColumn": 8,
"endLineNumber": 23,
"endColumn": 74,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/PreferencesDialog.java",
"code": "268435844",
"severity": 4,
"message": "The import javafx.beans.property.SimpleListProperty is never used",
"startLineNumber": 28,
"startColumn": 8,
"endLineNumber": 28,
"endColumn": 48,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/PreferencesDialog.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 73,
"startColumn": 21,
"endLineNumber": 73,
"endColumn": 26
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/PreferencesDialog.java",
"code": "16777788",
"severity": 4,
"message": "ObservableValue is a raw type. References to generic type ObservableValue<T> should be parameterized",
"startLineNumber": 73,
"startColumn": 28,
"endLineNumber": 73,
"endColumn": 43
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/PreferencesDialog.java",
"code": "16777788",
"severity": 4,
"message": "Class is a raw type. References to generic type Class<T> should be parameterized",
"startLineNumber": 81,
"startColumn": 30,
"endLineNumber": 81,
"endColumn": 35
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/PreferencesDialog.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 170,
"startColumn": 23,
"endLineNumber": 170,
"endColumn": 28
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/PreferencesDialog.java",
"code": "16777788",
"severity": 4,
"message": "SimpleControl is a raw type. References to generic type SimpleControl<F,N> should be parameterized",
"startLineNumber": 171,
"startColumn": 11,
"endLineNumber": 171,
"endColumn": 24
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/PreferencesDialog.java",
"code": "16777788",
"severity": 4,
"message": "Setting is a raw type. References to generic type Setting<E,P> should be parameterized",
"startLineNumber": 174,
"startColumn": 19,
"endLineNumber": 174,
"endColumn": 26
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/PreferencesDialog.java",
"code": "16777788",
"severity": 4,
"message": "Setting is a raw type. References to generic type Setting<E,P> should be parameterized",
"startLineNumber": 181,
"startColumn": 19,
"endLineNumber": 181,
"endColumn": 26
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/PreferencesDialog.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 181,
"startColumn": 140,
"endLineNumber": 181,
"endColumn": 145
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/PreferencesDialog.java",
"code": "16777788",
"severity": 4,
"message": "ObservableValue is a raw type. References to generic type ObservableValue<T> should be parameterized",
"startLineNumber": 181,
"startColumn": 147,
"endLineNumber": 181,
"endColumn": 162
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/PreferencesDialog.java",
"code": "16777788",
"severity": 4,
"message": "Setting is a raw type. References to generic type Setting<E,P> should be parameterized",
"startLineNumber": 182,
"startColumn": 9,
"endLineNumber": 182,
"endColumn": 16
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/PreferencesDialog.java",
"code": "16777788",
"severity": 4,
"message": "Field is a raw type. References to generic type Field<F> should be parameterized",
"startLineNumber": 194,
"startColumn": 27,
"endLineNumber": 194,
"endColumn": 32
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/PreferenceStorageHandler.java",
"code": "16777788",
"severity": 4,
"message": "ObservableList is a raw type. References to generic type ObservableList<E> should be parameterized",
"startLineNumber": 408,
"startColumn": 12,
"endLineNumber": 408,
"endColumn": 26
},{
"resource": "Quelea/src/main/java/org/quelea/windows/options/PreferenceStorageHandler.java",
"code": "16777788",
"severity": 4,
"message": "ObservableList is a raw type. References to generic type ObservableList<E> should be parameterized",
"startLineNumber": 410,
"startColumn": 13,
"endLineNumber": 410,
"endColumn": 27
},{
"resource": "Quelea/src/main/java/org/quelea/windows/pdf/PdfPanel.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable lp is not used",
"startLineNumber": 74,
"startColumn": 31,
"endLineNumber": 74,
"endColumn": 33,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/presentation/PowerPointHandler.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable process is not used",
"startLineNumber": 849,
"startColumn": 29,
"endLineNumber": 849,
"endColumn": 36,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/stage/StageDrawer.java",
"code": "268435844",
"severity": 4,
"message": "The import java.util.Iterator is never used",
"startLineNumber": 23,
"startColumn": 8,
"endLineNumber": 23,
"endColumn": 26,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/stage/StageDrawer.java",
"code": "570425421",
"severity": 4,
"message": "The value of the field StageDrawer.capitaliseFirst is not used",
"startLineNumber": 71,
"startColumn": 21,
"endLineNumber": 71,
"endColumn": 36,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/stage/StageDrawer.java",
"code": "536871061",
"severity": 4,
"message": "Dead code",
"startLineNumber": 306,
"startColumn": 39,
"endLineNumber": 306,
"endColumn": 110
},{
"resource": "Quelea/src/main/java/org/quelea/windows/stage/StageDrawer.java",
"code": "603979894",
"severity": 4,
"message": "The method dumbWrapText(String[]) from the type StageDrawer is never used locally",
"startLineNumber": 348,
"startColumn": 29,
"endLineNumber": 348,
"endColumn": 57,
"tags": [
        1
    ]
},{
"resource": "Quelea/src/main/java/org/quelea/windows/stage/StageDrawer.java",
"code": "536870973",
"severity": 4,
"message": "The value of the local variable maxLength is not used",
"startLineNumber": 382,
"startColumn": 13,
"endLineNumber": 382,
"endColumn": 22,
"tags": [
        1
    ]
}]
berry120 commented 1 year ago

These are almost always going to be code style issues rather than anything else. Quelea was originally written when Java 6 was the latest release - Java has changed a lot since then, so some of the code inevitably doesn't conform to best practice styles of later versions. As an example:

"ComboBox is a raw type. References to generic type ComboBox should be parameterized"

...reflects the fact that in Java 6, it was a raw type, and in Java 7+ it's parameterised - it's just never been updated (and updating it doesn't make any functional difference, it's just a code style thing.)

We occasionally pick up a few of them for people to address for Hacktoberfest, otherwise though tend to leave them be. If anyone wants to create a PR to address any then feel free, but it needs to be short, concise (no spaghetti PRs trying to fix everything at once!) and clear that there's no functional change / degradation.

jbubik commented 1 year ago

Thanks for explanation. I will try to help with the resource leaks a bit. I am making myself comfortable in this project now. Later I would like to contribute some more. We use Quelea since 2016 and it's cool.