quelea-projection / Quelea

Open source projection software for churches.
https://quelea.org
GNU General Public License v3.0
159 stars 145 forks source link

Stage View - Summary of Issues & major update #607

Open jbubik opened 1 year ago

jbubik commented 1 year ago

We use Quelea since 2016 and Stage View is the module we would like to start using now. IMHO it is not as easy to use as the rest of Quelea. I took time to review all Issues concerning Stage View and I had a look at StageDrawer.java. Found an additional undocumented bug - Stage View strips hints (//title //chords //lyrics) from the song. Later it 'guesses' the types of lines and gets them wrong. I believe it will be easier to fix StageDrawer.java with the big-picture in mind.

Summary of Issues

Course of action

We can discuss the big picture in this Issue. Detailed feature descriptions could be discussed in the specific Issues. Topics above, that have no issue, we can create an issue for them. Topics with multiple issues - can we close all of them but one. Implementing all of them together could save some effort - creating all the new settings in Options at once, all new translatable texts at once etc. If the project stakeholders think it is still better to separate them, so be it. I personally would like to help with Stage View with some coding and testing, but don't wanna cause unnecessary struggle in the project. Comments welcome!

Test data

A proposed test song. First verse a plain one, second verse full of hints and special cases:

Verse 1
C     D     E     F   G     A            H          C
Lorem ipsum dolor sit amet, consectetuer adipiscing elit.
C        D             E      F        G      A  H
Maecenas sollicitudin. Nullam feugiat, turpis at pulvinar
C          D    E      F         G       A   H        C
vulputate, erat libero tristique tellus, nec bibendum odio
C     D   E    F     G     A        H      C    D
risus sit amet ante. Fusce suscipit libero eget elit.

Test Title//title
A note to the band//note
Song 123 in our songbook B//note
      Amaj7       F  (slowly)//chords
Lorem ipsum dolor sit amet,//lyrics
C D E F G A H Cx//chords
C D E F G A H C//lyrics
jbubik commented 1 year ago

@berry120: can I start working on this?

JessyJP commented 1 year ago

I think they should be completely redone. If I am not wrong the songs get sent continuously. There are some reasons why this could be an easy and good method but it's not efficient. In addition to what you mentioned also, the transpose feature is completely missing.

Side question have you figured out how to produce an exe installer from the quelea code ?