search

quelea-projection / Quelea

Open source projection software for churches.
https://quelea.org
GNU General Public License v3.0
158 stars 145 forks source link

Bible book name caption #654

Closed kukymbr closed 4 months ago

kukymbr commented 4 months ago

In Zefania XML Bile in Russian (RST), the Bible book names are presented in the node inside the first chapter of each book. Added the parsing condition to handle this case.

Still cannot build the project on my M1, hope this is working.

kukymbr commented 4 months ago

Haven't got any java environment right now, wrote it without an interpreter; I am sorry for the syntax issues 🙄 The Bible XML is here: https://sourceforge.net/projects/zefania-sharp/files/Bibles/RUS/Russian%20Synodal%20Translation/

kukymbr commented 4 months ago

The book names are presented in this format:

 <BIBLEBOOK bnumber="1">
    <CHAPTER cnumber="1">
      <CAPTION vref="1">Первая книга Моисеева. Бытие</CAPTION>
      ...
kukymbr commented 4 months ago

Fixed my Golang syntax :)

berry120 commented 4 months ago

Thanks very much - made some minor changes to keep the caption parsing in the chapters where they are and fix a couple of things, hopefully all works now in the CI release 👍

kukymbr commented 4 months ago

Works fine, thank you

Screenshot 2024-05-11 at 00 57 35
berry120 commented 4 months ago

Lovely, you're welcome!

On Fri, 10 May 2024, 22:59 kukymbr, @.***> wrote:

Works fine, thank you Screenshot.2024-05-11.at.00.57.35.png (view on web) https://github.com/quelea-projection/Quelea/assets/28160439/22fc4985-2685-4312-95e4-2d96dd86e72b

— Reply to this email directly, view it on GitHub https://github.com/quelea-projection/Quelea/pull/654#issuecomment-2105318918, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZ6JDIBITVMC2ZHW653WQ3ZBU7K3AVCNFSM6AAAAABHRAPHUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVGMYTQOJRHA . You are receiving this because you modified the open/close state.Message ID: @.***>