search

quellus / GDTuber

A dynamic PNGTuber program made in Godot
MIT License
21 stars 12 forks source link

Setting to toggle full screen #6

Closed quellus closed 2 months ago

quellus commented 2 months ago

Having a transparent window start fullscreen is pretty scary if you don't expect it. The program should start windowed with a border to alleviate confusion and have a setting in the settings menu to toggle fullscreen.

spaghetticodefactory commented 2 months ago

Fixed with #31

spaghetticodefactory commented 2 months ago

thanks for unwinding my messy PR

Should I reintegrate my fullscreen toggle the same way I had it in the PR or do you have any feedback?

quellus commented 2 months ago

@spaghetticodefactory I think the only feedback we had was not to change the signals. They should be connected in the editor.

I’m not sure if I accidentally closed your PR or not. Sorry if I did