quentin-st / Munin-for-Android

Watch your munin-monitored servers on your Android devices
https://www.munin-for-android.com/
GNU General Public License v2.0
44 stars 7 forks source link

casting doesn't notice when the receiver dies. #11

Closed klaernie closed 9 years ago

klaernie commented 9 years ago

When the receiver died, the app didn't notice, it is still believing the receiver is running. (Noticed after chteuchteu/Munin-for-Android-Chromecast-Receiver#5)

quentin-st commented 9 years ago

I couldn't reproduce this issue, especially now that chteuchteu/Munin-for-Android-Chromecast-Receiver#5 is fixed. Now that it is, how could the receiver die when the app is still running?

klaernie commented 9 years ago

the best example would be a simple power failure on the chromecast, it crashing, changed network or lost wireless connection.

quentin-st commented 9 years ago

Could you try again? I just tried and it works as it should: I connected the app to the Chromecast, then unplugged its power source. Here is the log:

03-24 19:44:30.538  I/Chromecast﹕ onConnectionSuspended, cause: 2
03-24 19:44:30.548  E/GmsClient﹕ Calling connect() while still connected, missing disconnect() for com.google.android.gms.cast.service.BIND_CAST_DEVICE_CONTROLLER_SERVICE
03-24 19:44:43.758  I/MediaRouter﹕ Unselecting the current route because it is no longer selectable: MediaRouter.RouteInfo{ uniqueId=com.google.android.gms/.cast.media.CastMediaRouteProviderService:f257eee52dd23a98df8ca823766ae699, name=Chromecast3792, description=Application status is ready..., enabled=true, connecting=true, playbackType=1, playbackStream=-1, volumeHandling=0, volume=0, volumeMax=20, presentationDisplayId=-1, extras=Bundle[mParcelledData.dataSize=588], providerPackageName=com.google.android.gms }
03-24 19:44:43.768  I/Chromecast﹕ onRouteUnselected: info=MediaRouter.RouteInfo{ uniqueId=com.google.android.gms/.cast.media.CastMediaRouteProviderService:f257eee52dd23a98df8ca823766ae699, name=Chromecast3792, description=Application status is ready..., enabled=true, connecting=true, playbackType=1, playbackStream=-1, volumeHandling=0, volume=0, volumeMax=20, presentationDisplayId=-1, extras=Bundle[mParcelledData.dataSize=588], providerPackageName=com.google.android.gms }
03-24 19:44:43.768  I/Chromecast﹕ Shutting down connection
03-24 19:44:45.738  I/Chromecast﹕ Connection failed. Shutting down connection.
03-24 19:44:45.738  I/Chromecast﹕ Shutting down connection

The app knew about the disconnection about 20 seconds after it.

klaernie commented 9 years ago

It seems if is now behaving correctly. By the way: 24h later it is still successfully casting (and updating) despite my phone leaving the WiFi numerous times.

quentin-st commented 9 years ago

Good news! Thank you for testing it!