quentin452 / DangerRPG-Continuation

Just a continuation of DangerRPG for 1.7.10
GNU General Public License v3.0
5 stars 1 forks source link

incorrect damage for melee weapons hbm #57

Open kotmatross28729 opened 11 months ago

kotmatross28729 commented 11 months ago

Desktop Screenshot 2023 11 07 - 16 02 57 84 This is the last meteorite sword in hbm, and its damage = +500, however, in general, all meteorite swords from DangerRPG have +4 damage.

similar with the cobalt and star metal swords. With DangerRPG their damage is 5-6, although in the original it is 15 and 25 respectively. Is there a way to fix this without changing the settings manually?

Also, armor from hbm (like tools) in the creative menu with 0 charge, although in the original it is always maximum.

quentin452 commented 11 months ago

(for bugged strenght sword) i think that bug will be useless when i add more way to lvl etc.. (you can see enhancement) in the github repo

and " in the creative menu with 0 charge" , i think that can be fixed by recharging it?

kotmatross28729 commented 11 months ago

1) I didn’t quite understand what you meant, this sword (the last one) has damage equal to 500 without DangerRPG, and with it 4, what does the level have to do with it?

2) Yes, in survival, armor and tools are crafted unloaded, but in creative they are charged to the maximum, for more convenient use (you take an item from creative immediately charged, and you can use it, this is especially useful if the item requires some kind of liquid for use , because in order to test it (with DangerRPG) you need to put a tank, pour liquid into it, wait for the item to be filled, etc., when without DangerRPG you just take a thing from creative, and you can immediately use it) I think this is just right due to the level system, and it possibly breaks the nbt tag responsible for the charge of the item/armor

quentin452 commented 11 months ago

1 : did you see Strenght from the RPG GUI(in stats)? thats what i mean , adding new way to make stats https://github.com/quentin452/DangerRPG-Continuation/issues/41

quentin452 commented 11 months ago

2 : the issue seem to come from isAllItemsRPGable

kotmatross28729 commented 11 months ago

in V1.1.4.3 there are no bug with incorrect damage for hbm melee weapons , but there is still a bug with the charge of armor/tools in the creative menu (also hbm armor does not show up as armor in the DangerRPG menu), and I can confirm that with B:isAllItemsRPGable=false there are no problem with items charge in creative