search

quentincaffeino / godot-console

In-game console for Godot 3.
MIT License
668 stars 49 forks source link

Use theme file to define styles of the controls #67

Closed SpyrexDE closed 3 years ago

SpyrexDE commented 3 years ago

Using a Console.theme file, that the user is able to edit with ease, would enable every user to adjust the style of the console to fit their game's style. Also, things like increasing the console's font size on bigger screens would get possible. I think it even will save a bit of memory. Would be a great and relatively easy to do upgrade :)

quentincaffeino commented 3 years ago

Sounds interesting however I'm very bad with ui in godot and coming from web godot ui feels very painful. Current ui wasn't made by me.

If you can help me with that I'll gladly accept a pr.

To give you a better perspective on my ideas: I'm aware of this problem. Currently this project is more of a library, but I plan to make this into a framework which would allow to customize almost anything. See #24

SpyrexDE commented 3 years ago

Sounds good. I would like to help, but it's hard for me to understand and debug the project structure and code guidelines/tools you use. It looks a bit too "professional" and I have no clue how to work with this ;D I am convinced that I would get it working, but I am not sure if you will be happy with how I implemented it. 🤔

Maybe I could contribute to this project when you have some resources or explanations for me to get into your workflow a bit.

quentincaffeino commented 3 years ago

Correct me if I'm wrong, but to create a theme file you need to work only with tscn file? Currently whole console ui is in a single tscn file. See https://github.com/quentincaffeino/godot-console/blob/develop/addons/quentincaffeino/console/src/Console.tscn. So as long as you don't change the tree structure of the scene it should be fine.

SpyrexDE commented 3 years ago

Oh yes, you are right. At first, I thought about maybe a settings window for the addon where you can then adjust settings like the theme, but of course, this is one step too much yet. However, I also wouldn't decline to help out with real programming stuff and learn about your project structure. :)