quentinlampin / ngx-openlayers

Angular2+ components for Openlayers 4.x
Mozilla Public License 2.0
137 stars 98 forks source link

Add definitely-type OpenLayers typings and use to fix type mismatches #244

Closed maurizi closed 4 years ago

maurizi commented 4 years ago

Mostly this is effectively non-functional changes to note which interfaces each component implements, with a few tweaks where the typings were incorrect, and also fixes a few incorrect imports that didn't work at all (most notably for me, the SourceVectorTileComponent had incorrect imports, which is what led me to type check this project).

This should fix #235

maurizi commented 4 years ago

@Neonox31 @Yakoust any interest in merging this PR? It looks like it conflicts with #245, so I'd understand if the answer is no, but of particular interest to me is seeing the imports in SourceVectorTileComponent fixed

maurizi commented 4 years ago

Superseded by #247