search

quentinlampin / ngx-openlayers

Angular2+ components for Openlayers 4.x
Mozilla Public License 2.0
137 stars 98 forks source link

Unable to remove default controlls #47

Closed FallenRiteMonk closed 7 years ago

FallenRiteMonk commented 7 years ago

Hy,

there is currently no possibility to remove the default controls added to a map or change there options, or at least I didn't find a way to do it. I found the DefaultControlComponent, but it's inputs do not affect the component in any way! Is there some code missing or am I overseeing something.

achimha commented 7 years ago

Yes, I think that is a bug. The documentation states:

Controls initially added to the map. If not specified, ol.control.defaults() is used.

As we have a separate directive for the default components, we should explicitly set the member to an empty collection.

achimha commented 7 years ago

Created a PR: https://github.com/quentin-ol/angular2-openlayers/pull/49

quentin-ol commented 7 years ago

Thanks, nice work!