quentinlesceller / macmediakeyforwarder

Media Key Forwarder for iTunes and Spotify
The Unlicense
204 stars 7 forks source link

Mac Sonoma support #15

Open spiritonline opened 10 months ago

spiritonline commented 10 months ago

Hi,

I'm looking for something to control the volume of Spotify on Mac Sonoma using the FN volume keys on the keyboard. I was hoping this was the solution but it doesn't work. I play via Spotify connect to a device if that makes a difference.

samuelbeaulieu commented 10 months ago

If you select "Prioritize Spotify" it does work on Sonoma.

Screenshot 2023-11-02 at 11 51 49 AM
pg42819 commented 10 months ago

same for me - doesn't work on sonoma for controlling the spotify app. system settings are good - in Accessibility AND Automation

sebastiaanluca commented 10 months ago

Same on Sonoma 14.0, but getting this warning popup:

Screenshot 2023-11-06 at 17 41 25

Enabled in both places though:

Screenshot 2023-11-06 at 17 41 39 Screenshot 2023-11-06 at 17 41 30

Opening the command itself from within the package in Terminal and keeping it running works fine, so might hint in the direction of the menu bar wrapper not starting the command internally.

sebastiaanluca commented 10 months ago

For what it's worth, I used ChatGPT and my ancient Xcode knowledge to rebuild the app for macOS Sonoma and that seems to work. After fixing one deprecation, there are a ton remaining but mostly warnings for now. Can't share since it's not code signed and probably not up to standard though.

HackettLai commented 9 months ago

I've noticed that this functionality only works when Spotify is open and actively playing music. If not, the play button continues to launch the Apple Music App instead.

MacOS: 14.1.2 (23B92) macmediakeyforwarder: 3.1.2 (build 1)

Screen Record: https://github.com/quentinlesceller/macmediakeyforwarder/assets/56993446/6e5eab98-e884-4794-8dec-676afd4c0745 CleanShot 2023-12-01 at 15 36 29

blujjensen commented 8 months ago

Jan. 2024 Still having the same issue of the app not opening/working. 280782207-31d59638-e4dd-4e34-8127-32b6cea1490c 280782275-c1643276-340f-4ff7-9bd7-a84ab7857e73 280782278-8f1d58a0-b577-4aee-893f-a3152d5bbad0

lmkunert commented 7 months ago

Jan. 2024 Still having the same issue of the app not opening/working. 280782207-31d59638-e4dd-4e34-8127-32b6cea1490c 280782275-c1643276-340f-4ff7-9bd7-a84ab7857e73 280782278-8f1d58a0-b577-4aee-893f-a3152d5bbad0

same issue here

jhagege commented 5 months ago

Jan. 2024 Still having the same issue of the app not opening/working. 280782207-31d59638-e4dd-4e34-8127-32b6cea1490c 280782275-c1643276-340f-4ff7-9bd7-a84ab7857e73 280782278-8f1d58a0-b577-4aee-893f-a3152d5bbad0

same issue here

Same here, did you manage to solve?

samuelbeaulieu commented 5 months ago

This is my .app file. For me, it works as expected. When I press play, it opens Spotify (even if it's closed). Then I can control Spotify, like I would with Apple Music. I don't know if my .app is going to make a difference...

MacMediaKeyForwarder.zip

Menu app

Screenshot 2024-04-03 at 9 26 33 PM

System Pref -> Privacy

Screenshot 2024-04-03 at 9 27 41 PM Screenshot 2024-04-03 at 9 28 03 PM
HackettLai commented 5 months ago

This is my .app file. For me, it works as expected. When I press play, it opens Spotify (even if it's closed). Then I can control Spotify, like I would with Apple Music. I don't know if my .app is going to make a difference...

MacMediaKeyForwarder.zip

Menu app

Screenshot 2024-04-03 at 9 26 33 PM

System Pref -> Privacy

Screenshot 2024-04-03 at 9 27 41 PM Screenshot 2024-04-03 at 9 28 03 PM

Did you made any code changes on this version?

samuelbeaulieu commented 5 months ago

This is my .app file. For me, it works as expected. When I press play, it opens Spotify (even if it's closed). Then I can control Spotify, like I would with Apple Music. I don't know if my .app is going to make a difference...

MacMediaKeyForwarder.zip

Menu app

Screenshot 2024-04-03 at 9 26 33 PM

System Pref -> Privacy

Screenshot 2024-04-03 at 9 27 41 PM Screenshot 2024-04-03 at 9 28 03 PM

Did you made any code changes on this version?

No code changes.

I also tried installing the app again earlier tonight. I cloned the repo, changed the bundle identifier & provisioning profile. Ran the app from Xcode, made sure it was setup correctly and it worked well again. (The other version, the original, was fully closed for that test.)

hectorpal commented 3 months ago

I just installed via brew the version 3.1.2 of macmediakeyforwarder. That matches the corresponding release in this repo. I'm in Sonoma 14.4.1 (23E224).

Two things:

  1. The release says the app is now signed, but I still had to approve it via security settings.
  2. The Application only shows in Automation settings when I press play after choosing one of the applications in the menu of macmediakeyforwarder. When I press play, macOS requests the permission mentioned before. I did it first with Spotify. Then, with App Music.

It's working well. Even if I'm at the App Music, the Play event goes to Spotify.

HackettLai commented 3 months ago
  1. I remove the existing app
  2. Reinstall the last version
  3. Run Terminal and run codesign --force --deep --sign - /Applications/MacMediaKeyForwarder.app to code sign it manually.
  4. Open [System Settings -> Privacy & Security -> Accessibility] remove the MacMediaKeyForwarder.app and then add it back again manually.
  5. Go to [System Settings -> Privacy & Security -> Automation] disable and enable both "Music" & "Spotify"
  6. Open the MacMediaKeyForwarder.app
  7. Open setting check the option "Pause if no player is running"
  8. Done

Currently, if Spotify is open, the play button will forward to Spotify. If it is not open, Apple Music will be launched.

Note: It would be great if the play button could open Spotify if it isn't already open, but the current functionality is still quite good.