quentinsf / icsv2ledger

Interactive importing of CSV files to Ledger
196 stars 70 forks source link

bug: fails without explicitly setting a --ledger-file value #102

Closed ajamian closed 7 years ago

ajamian commented 7 years ago

Thank you for an excellent utility!

I started using about a year ago. A couple months ago I finally updated my local clone to your latest changes and found that the commands I had been using were failing. After some debug, it appears that the codeflow without a --ledger-file passed bypasses the only logic that initializes a couple of sets, without these initialized the code fails later.

Also noticed that the utility now assumes the ledger executable is in the current PATH.

I have a bugfix in my fork of the tool, as well as a small edit to the README stating that the ledger binary must be in the current shell PATH. Happy to open a pull request.

petdr commented 7 years ago

Thanks for the pr.