quentinsf / icsv2ledger

Interactive importing of CSV files to Ledger
196 stars 70 forks source link

Documentation: --desc should be integer #136

Open fleimgruber opened 4 years ago

fleimgruber commented 4 years ago

The docs state

--desc STR            CSV column number matching description
--effective-date INT  CSV column number matching effective date

which should read

--desc INT            CSV column number matching description
--effective-date INT  CSV column number matching effective date

Or even better, specify CSV column by name since ordering of columns might be arbitrary depending on tools prior in the CSV transformation chain.

areynoua commented 2 years ago

This is STR because one can specify a comma-separated list of column indices.

fleimgruber commented 2 years ago

Thanks for checking back, has been a while.

This is STR because one can specify a comma-separated list of column indices.

This should be mentioned in the docs then? E.g.

--desc STR            CSV column number or comma-separated list of column indices matching description

and I am wondering how a description can be taken from multiple columns? Does it just concatenate all the column values then?