search

quentinsf / icsv2ledger

Interactive importing of CSV files to Ledger
196 stars 70 forks source link

Only saves to ledger file when --incremental option is used #96

Closed KevinCaseiras closed 7 years ago

KevinCaseiras commented 8 years ago

After running the command: ./icsv2ledger.py -c config.txt -a CHASE ChaseCredit.csv ledger.dat the ledger.dat file is empty unless I use the --incremental option.

The above command works on previous commits, which makes me believe it is a bug.

I will be submitting a PR with a fix if you are interested. To fix this, my PR makes icsv2ledger always write to the ledger file incrementally. Therefore the only functionality of the --incremental flag is to append to the ledger file instead of overwriting. Let me know if you would prefer it be renamed to --append. I didn't want to break backwards compatibility. Consequently I fixed the incompatibility between the --reverse and --incremental options.

themiurgo commented 7 years ago

I'm also experiencing this issue.