search

quequotion / pantheon-qq

Pantheon derivatives, experimental packages, and accessories
10 stars 4 forks source link

Not a git url #7

Closed SolarAquarion closed 4 years ago

SolarAquarion commented 4 years ago

https://github.com/quequotion/pantheon-qq/blob/f0db4cccceaf18ae91b3bf0b30ba8d61fd19f4c4/pantheon-dock-instctl-git/PKGBUILD#L9

quequotion commented 4 years ago

This is a link to a reddit post with a video demonstrating the "instance controls" patch.

I have not yet made a pull request against Dock on github to be linked. The only other place to link would be the merge request against Plank on launchpad.

This is not a link to get more info bout Dock, it is a link to get more info about my patch.

SolarAquarion commented 4 years ago

But the git leads to the url

On Sat, Oct 17, 2020, 12:39 AM Que Quotion notifications@github.com wrote:

This is a link to a reddit post with a video demonstrating the "instance controls" patch.

I have not yet made a pull request against Dock on github to be linked. The only other place to link would be the merge request https://code.launchpad.net/~quequotion/plank/+git/plank/+merge/390649 against Plank on launchpad.

This is not a link to get more info bout Dock, it is a link to get more info about my patch.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/quequotion/pantheon-qq/issues/7#issuecomment-710747493, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIPVCFOZFCRGJQGFI27JL3SLENWVANCNFSM4SQZXFNQ .

quequotion commented 4 years ago

omg! I just realized what you are talking about

I need to fix line 16

source=(pantheon-dock::git+$url

The original PKGBUILD could use $url there because the "info" and source link were the same. I must have made that change after building it locally. Oops.

quequotion commented 4 years ago

fixed in commit ac9eefc28507fd90f653e48edabc4edf83bb6457