queraltab / Greenhouses-Library

The Greenhouse Modelica Library aims at providing a fully open-source modeling framework for the simulation of greenhouse climate, crop yield and the energy integration of greenhouses with thermal systems (e.g. generation units, thermal storage units, district heating networks, etc.).
BSD 3-Clause "New" or "Revised" License
47 stars 18 forks source link

Unresolvable parameter in annotation #13

Closed svorkoetter closed 5 years ago

svorkoetter commented 5 years ago

When flattening the GlobalSystem_2 example, MapleSim issues a warning that the name PumpType in an annotation in Greenhouses.Flows.FluidFlow.Pump_Mdot cannot be resolved. Searching through the entire source code, the only place this name appears is Flows/FluidFlow/Pump_Mdot.mo, once in the offending annotation,

parameter Real eta_is=1 "Overall Isentropic efficiency of the pump" annotation (Dialog(enable= (PumpType == "User Defined")));

and once in the Documentation annotation:

<li>PumpType: select between different performance curves for isentropic and volumetric efficiencies.</li>

The parameter isn't actually defined anywhere.

queraltab commented 5 years ago

The "enable" annotation was related to an obsolete parameter because it was used in a previous version of the model. The actual model does no longer make use of this parameter. The annotation has been removed so the issue is solved. Thanks for your collaboration!