querqy / chorus

Towards an open source stack for e-commerce search
Apache License 2.0
141 stars 33 forks source link

keycloak/check-for-host-configuration.sh echo with -e mangles windows path #143

Open cgicgi opened 1 year ago

cgicgi commented 1 year ago
-  echo -e "${ERROR}To make Keycloak work, you need to add the following line to your hosts file (/etc/hosts on Mac/Linux, c:\Windows\System32\Drivers\etc\hosts on Windows).${RESET}"
+  echo "${ERROR}To make Keycloak work, you need to add the following line to your hosts file (/etc/hosts on Mac/Linux, c:\Windows\System32\Drivers\etc\hosts on Windows).${RESET}"
epugh commented 1 year ago

would you like to submit a PR? I don't have access to windows, so it would be great if you could submit a PR that passes on windows!

cgicgi commented 1 year ago

I'd love to - but don't have permissions to push my branch with the fix.

epugh commented 1 year ago

Just fork this project into your own namespace, and submit a PR ;-) That gives us a nice review cycle.