querydsl / apt-maven-plugin

Maven APT plugin
Apache License 2.0
79 stars 41 forks source link

Misleading Documentation of "include" and "exlcude" Compilation Options #23

Closed Reza-Senacor closed 10 years ago

Reza-Senacor commented 11 years ago

According to the documentation of apt-maven-plugin mentioned options should enlist the directories in a form like /.../targetdir/*.java.

This is not true, because the values for these options should be expressed as java packag names e.g. com.mypackage.mydomain.mydao.**

The plugin raises no error, it ignores given options, in case the format is wrong

timowest commented 10 years ago

@Reza-Senacor Do you refer to this documentation? https://github.com/querydsl/apt-maven-plugin/blob/master/src/main/java/com/mysema/maven/apt/AbstractProcessorMojo.java#L80

Reza-Senacor commented 10 years ago

Hi Timo, yes, exactly that is was I meant. Thx

timowest commented 10 years ago

Ok, so I can close it, since it seems to be in the format you suggest. Do you agree or did I miss something?

timowest commented 10 years ago

Closing for now, since the documentation seems to be correct regarding includes/excludes.