querydsl / apt-maven-plugin

Maven APT plugin
Apache License 2.0
79 stars 41 forks source link

Patch for m2e 1.1+ integration (incremental build support) #3

Closed mzachar closed 12 years ago

mzachar commented 12 years ago

This patch allows you to use mysema apt maven plugin inside eclipse (supporting incremental build) out of box without 3rd-party eclipse plugin.

There is an enhancement for filtering packages from which java sources are processed for apt. It is usefull when there is lot of files changes which are not eligible for querydsl apt processing. e.g.: include only sources from "bo" packages for apt processing

I propose artifact name change as artifact ids of the format maven-___-plugin are reserved for plugins in the group id org.apache.maven.plugins. In the future this may cause the build to break.

timowest commented 12 years ago

Thanks for the patch. I have a few improvement suggestions.

Could you indent the code properly and move the source code scanning to a separate method.

mzachar commented 12 years ago

I'm not sure about the indent I used build-in eclipse formater to format indents and I can see it in my workspace matching correctly however in commit diff it does not look like it match. Is there something I can do different to make it appear correctly in the diff as well?

mzachar commented 12 years ago

I found the problem - eclipse by default is using tabs for indents but the source was indented by using 4 spaces. Should be correct now :)

timowest commented 12 years ago

Thanks a lot for this contribution

timowest commented 12 years ago

I reverted the artifactId for now. Where is the reservation of the maven-___-plugin pattern defined.

mzachar commented 12 years ago

see issue: http://jira.codehaus.org/browse/MPLUGIN-185

Its now live with latest maven - you actually get this warring when you try to build your plugin. It's a question of time when this will get enforced more than with a warning