search

querydsl / codegen

Java/Scala Code generation tool
Apache License 2.0
23 stars 22 forks source link

DefaultEvaluatorFactory has a hard dependency on EvaluatorFactory #3

Closed Maia-Everett closed 12 years ago

Maia-Everett commented 13 years ago

DefaultEvaluatorFactory internally creates an instance of EvaluatorFactory with no way to override it with a custom subclass of EvaluatorFactory, short of subclassing DefaultEvaluatorFactory and copy-pasting all its methods.

Please provide a constuctor for DefaultEvaluatorFactory that accepts a custom instance of EvaluatorFactory.

timowest commented 12 years ago

Sorry for replying with such a huge delay. I have to fix my GitHub notifications.

The classnames have changed a bit, could you update the issue?

Maia-Everett commented 12 years ago

Sorry about the confusion. DefaultEvaluatorFactory is in querydsl-collections.

https://github.com/mysema/querydsl/blob/master/querydsl-collections/src/main/java/com/mysema/query/collections/DefaultEvaluatorFactory.java

There is no way for the user to supply their own EvaluatorFactory.

timowest commented 12 years ago

Fixed in Querydsl https://github.com/mysema/querydsl/commit/ffc309ecb0b4365915a47d89d6b6f2b788661b4c