Update COMPARABLE TypeCategory so that java.util.UUID instances are deemed to be comparable

querydsl / codegen

Java/Scala Code generation tool

Apache License 2.0

23 stars 22 forks source link

Update COMPARABLE TypeCategory so that java.util.UUID instances are deemed to be comparable #41

Open selimnairb opened 6 years ago

selimnairb commented 6 years ago

The change in this PR solves querydsl issue 2220 (https://github.com/querydsl/querydsl/issues/2220, which is documented in more detail here: https://groups.google.com/forum/m/#!msg/querydsl/iS0fNn16EO4/Hj6JJ3ACAgAJ).

selimnairb commented 6 years ago

Hi @Shredder121. I am new to this code so I am not sure I follow. Can you elaborate?

Shredder121 commented 6 years ago

I mean, semantically the sub-COMPARABLE TypeCategories will then inherit the java.util.UUID type as valid type. Better to fix it in the module where it's used. I'll leave this open, but I would fix it in Querydsl proper.