querylab / lazywarden

Automatic Bitwarden Backup
MIT License
392 stars 4 forks source link

[Suggestion] Move readme images from imgur to github storage. #5

Open BJReplay opened 1 week ago

BJReplay commented 1 week ago

Create a screenshots folder in your github source (eg .github/SCREENSHOTS) and upload all the original png files from imgur to that folder, then re-link all the links from imgur to those github images).

That will remove the dependency on imgur, and it serving ads around your images - unless, of course, you're trying to monetise this project via imgur ads 🤣

It will make for quicker reading of the readme, as well if users don't need to wait for imgur to slowly load the scaled smaller image, and then to right click and show original to display a large original.

P.S. Let me know if you'll accept a PR for this, and I'll do it, but if you're actively edit the readme, my update is likely to trample on your edits and at best present a messy merge, so I haven't just submitted a massive PR.

querylab commented 1 week ago

You're absolutely right, moving the images to GitHub is an excellent idea to remove the dependency on Imgur and improve the reading experience. I hadn't thought of it that way because it made it faster to upload the images to Imgur. Also, I'm working on a more detailed documentation page, something similar to https://www.lazyvim.org which will make it even easier to access the information. I hope to have it ready very soon.

This should speed up the loading of images and avoid any problems with third party ads. And no, I'm not trying to monetize the project through Imgur! 😄 I didn't even know you could monetize through Imgur 🤣