queryverse / DataVoyager.jl

Julia wrapper for the Voyager data exploration tool
Other
128 stars 11 forks source link

Cannot start Voyager because of name of user directory #45

Closed fbanning closed 3 years ago

fbanning commented 3 years ago
julia> using DataVoyager

julia> Voyager()

ERROR: Path contained unexpected character
Stacktrace:
 [1] error(::String) at .\error.jl:33
 [2] parse_url(::String) at C:\Users\Frederik Banning\.julia\packages\URIParser\IuWoB\src\parser.jl:278
 [3] URI at C:\Users\Frederik Banning\.julia\packages\URIParser\IuWoB\src\parser.jl:312 [inlined]
 [4] Voyager() at C:\Users\Frederik Banning\.julia\packages\DataVoyager\71yWt\src\DataVoyager.jl:23
 [5] top-level scope at REPL[5]:1

I suppose the problem might have to do with the space in my user directory path. Is this assumption correct? What can we do to avoid such an error?

MikaelFiil commented 3 years ago

I seem to have the same problem, did you solve it?

fbanning commented 3 years ago

No, I didn't solve it. I simply stopped trying to use DataVoyager and resorted to other means of data exploration. Sorry.

ryanbrownnetworking777 commented 3 years ago

I have this same issue, is there any resolution on this?

fbanning commented 3 years ago

I have not found one and stopped trying to use DataVoyager.jl as a result because I couldn't get it working.

ryanbrownnetworking777 commented 3 years ago

@fbanning I figured out what was the problem at least for me. Data Voyager for me wasn't properly encoding spaces and the URI library wasn't able to parse the string. I have spaces in my user directory as well as the environment name I was using at the time, so Data Voyager wouldn't work. I've updated part of the DataVoyager.jl code on my local machine to replace spaces with the proper web encodings. I'm going to see if I can't get a change for this done and submit for a PR. Because this really is an issue that should be fixed.

ryanbrownnetworking777 commented 3 years ago

@fbanning I forked and made the change in my forked branch. I created a PR to merge that change into master here. Hopefully they get to it soon, either accepting my PR or implementing the functionality themselves.

davidanthoff commented 3 years ago

Should be fixed now.