search

queryverse / ElectronDisplay.jl

An Electron.jl based figure and table display.
Other
85 stars 17 forks source link

Support application/vnd.dataresource+json #10

Closed tkf closed 5 years ago

tkf commented 5 years ago

Use ag-grid as in TableView.jl. electrondisplay(dataset("cars")) now shows:

image

davidanthoff commented 5 years ago

Very cool!!

davidanthoff commented 5 years ago

Alright, couple of more points:

I thought all of queryverse supported that MIME type, but that was actually wrong. A whole bunch of packages didn't so far. But, here are the PRs that add it across the board: https://github.com/queryverse/QueryOperators.jl/pull/24, https://github.com/queryverse/CSVFiles.jl/pull/41, https://github.com/queryverse/StatFiles.jl/pull/9, https://github.com/queryverse/FeatherFiles.jl/pull/10 and https://github.com/queryverse/ExcelFiles.jl/pull/25.

And everything works with the pipe! So things like load("foo.feather") |> electrondisplay, df |> @select(-:barCol) |> electrondisplay etc. all work!

Oh, and I think we should probably also just copy this functionality over into the VS Code extension. Given how little code it is, that should be fairly straightforward, so I can probably take a go at it (unless you want to try!).

I'm also wondering whether we might at some point have some special API for the grid, that would work in VS Code and here. Say a grid() function or something like that... But I don't think that is urgent, for now this is really all just an amazing addition in terms of functionality!

tkf commented 5 years ago

queryverse/QueryOperators.jl#24, queryverse/CSVFiles.jl#41, queryverse/StatFiles.jl#9, queryverse/FeatherFiles.jl#10 and queryverse/ExcelFiles.jl#25.

Awesome, it's great to have a broad support for the dataresource API.

Given how little code it is, that should be fairly straightforward, so I can probably take a go at it (unless you want to try!).

Well, I'm not using VS Code so I guess I'll let you try :)

Say a grid() function or something like that...

Quicker and frontend-agnostic way to view tables sounds nice. But I guess I need to use it for a while to see what would be a good UI.