search

queryverse / ElectronDisplay.jl

An Electron.jl based figure and table display.
Other
85 stars 17 forks source link

Use ConstructionBase.setproperties instead of hand-coding setconfig #35

Open tkf opened 4 years ago

tkf commented 4 years ago

I suggest using ConstructionBase.setproperties instead of the manually coded setconfig.

codecov-io commented 4 years ago

Codecov Report

Merging #35 into master will decrease coverage by 0.18%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   80.76%   80.58%   -0.19%     
==========================================
  Files           2        2              
  Lines         104      103       -1     
==========================================
- Hits           84       83       -1     
  Misses         20       20
Impacted Files Coverage Δ
src/ElectronDisplay.jl 77.01% <100%> (-0.27%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update de9d797...cbe022d. Read the comment docs.

davidanthoff commented 4 years ago

I like this, but maybe we can wait until ConstructionBase.jl has hit 1.0.0 and follows normal semver semantics? Maybe that is something that can already happen over there?

tkf commented 4 years ago

I think that's a reasonable concern. I brought this up in https://github.com/JuliaObjects/ConstructionBase.jl/issues/6#issuecomment-541283051