queryverse / ElectronDisplay.jl

An Electron.jl based figure and table display.
Other
85 stars 17 forks source link

Move react app into separate repo #51

Closed davidanthoff closed 4 years ago

davidanthoff commented 4 years ago

Ok, I've changed my mind again :) But now that I understand the structure of all of this better, I think @TonyLianLong you were right to suggest we put the actual react app into a separate repo. I created one at https://github.com/julia-vscode/plotgallery and gave you access rights for that. Can you just add the whole content of the folder electron-display-react to that repo and remove it from the PR for this repo here?

And then we will add the content of the build folder here into the ElectronDisplay repo. I think for now we can just manually copy things in here.

But as you pointed out, with such a structure it should be easier to use the same code for electron display and inside VS Code itself.

davidanthoff commented 4 years ago

This is done: https://github.com/julia-vscode/plotgallery/