queryverse / IterableTables.jl

Implementations of the TableTraits.jl interface for various packages
Other
79 stars 9 forks source link

IterableTables affects general usage of DataTables #54

Closed CiaranOMara closed 6 years ago

CiaranOMara commented 7 years ago

IterableTables breaks base functionality of the DataFrames.DataFrame(::Array{Int64,2}) constructor.

using DataFrames
arr = [1 2 3; 4 5 6]

df_from_array = DataFrame(arr)

df = DataFrame(Name=["John", "Sally", "Jim"], Age=[34.,25.,67.], Children=[2,0,3])

using IterableTables

df2 = DataFrame(Name=["John", "Sally", "Jim"], Age=[34.,25.,67.], Children=[2,0,3])

df_from_array2 = DataFrame(arr)

Below is the error that occurs during assignment of df_from_array2.

➜  julia test-IterableTables.jl                                                                                          21:30:56
ERROR: LoadError: 
Stacktrace:
 [1] DataFrames.DataFrame(::Array{Int64,2}) at /Users/comara/.julia/v0.6/IterableTables/src/integrations/dataframes.jl:126
 [2] include_from_node1(::String) at ./loading.jl:569
 [3] include(::String) at ./sysimg.jl:14
 [4] process_options(::Base.JLOptions) at ./client.jl:305
 [5] _start() at ./client.jl:371
while loading /Users/comara/Documents/Julia/Tests/test-IterableTables.jl, in expression starting on line 12
davidanthoff commented 7 years ago

That was a good find, thanks! I have it fixed on master now. I hope to get a new release out soon. There is a fair bit of other churn, so it might be a couple of days, though. Don't try to use master at this point, it depends on things in other packages.

davidanthoff commented 6 years ago

Closing since DataTables is no more.