search

queryverse / IterableTables.jl

Implementations of the TableTraits.jl interface for various packages
Other
79 stars 9 forks source link

Avoid type piracy #75

Closed quinnj closed 6 years ago

quinnj commented 6 years ago

I think it would be a little more kosher for types like DataFrame to implement collect(e::Enumerable, ::Type{DataFrame}) (which would be a more specific method than the default fallback) instead of stealing the DataFrame(x::Any) definition.

davidanthoff commented 6 years ago

Closing as the constructor approach now seems widely accepted, plus the code for DataFrames.jl now lives in DataFrames.jl itself, so no more type piracy there.