search

queryverse / IterableTables.jl

Implementations of the TableTraits.jl interface for various packages
Other
79 stars 9 forks source link

Fix DataFrames integration #81

Closed davidanthoff closed 6 years ago

davidanthoff commented 6 years ago

Fixes #80.

codecov[bot] commented 6 years ago

Codecov Report

Merging #81 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #81   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          10     10           
=====================================
  Hits           10     10
Impacted Files Coverage Δ
src/integrations/dataframes.jl 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 16940f5...8b07687. Read the comment docs.

femtotrader commented 6 years ago

I wonder if a property columns shouldn't be add to DataFrame. getproperty could help https://github.com/JuliaLang/julia/pull/24960

davidanthoff commented 6 years ago

I wonder if a property columns shouldn't be add to DataFrame.

I actually don't think so. If that was done one couldn't access a column named columns with the dot syntax anymore.