search

queryverse / IterableTables.jl

Implementations of the TableTraits.jl interface for various packages
Other
79 stars 9 forks source link

Load DataFrames integration only for old versions of DataFrames #85

Closed davidanthoff closed 5 years ago

davidanthoff commented 6 years ago

@quinnj, I think this is a more robust version than #84, right? Given that we can't use version ranges for the things in a @require file, we still need the integration in this package here to load for DataFrames.jl versions that don't yet have the Tables.jl integration. I think this code here achieves that?

It also would make it very easy to phase all of this in: we can merge this here first and tag a release, and then tag a DataFrames.jl release, and there won't even be a short time in between where things won't work.

When I ran the tests here with the new Tables.jl version of DataFrames.jl, some tests didn't pass, though. I'll write down the details of that in the DataFrames.jl PR, because I think it would have to be fixed there.

quinnj commented 5 years ago

Merge and tag? We're ready to merge DataFrames.

quinnj commented 5 years ago

We're going to merge DataFrames PR to master today around noon; can we merge this as well?

quinnj commented 5 years ago

Is there anyone else who can merge this? It seems @davidanthoff is offline or otherwise unable to merge. We've merged the corresponding DataFrames PR and are planning to do a release this weekend.