search

queryverse / Query.jl

Query almost anything in julia
Other
395 stars 50 forks source link

[WIP] Added checking for valid columns in select #317

Closed AliMalik9599 closed 3 years ago

AliMalik9599 commented 4 years ago

I've added some testing to validate if a column name or position exists/does anything when using the select macro. I was slightly confused as to the code for eltype and range selecting, but this is a work in progress and tried to contribute what I could.

davidanthoff commented 3 years ago

Thanks, and sorry for not looking at this earlier, my fall semester was a bit chaotic.

I think this in general can't be implemented here in Query.jl: the macro here just generates code that then later at runtime processes the data, but during the macro phase you don't have access to the source data, and therefore can't validate anything. The place to implement this is somewhere in QueryOperators.jl.