search

queryverse / QuerySQLite.jl

SQLite backend for Query.jl
Other
4 stars 2 forks source link

Drop df dep #1

Closed davidanthoff closed 5 years ago

davidanthoff commented 5 years ago

Actually, lets wait with a merge for a moment, I have a few more things I want to fix here!

davidanthoff commented 5 years ago

Alright, ready for CI and review.

I changed the tests a bit around.

bramtayl commented 5 years ago

Maybe it's worth checking in with the SQLite.jl folks before we merge this?

davidanthoff commented 5 years ago

I think we can just merge it for now? I'm not too worried about it. I've also been thinking about another strategy for this in general, so I think before we move anything upstream, I'd like to ponder it a bit more.