search

queryverse / QuerySQLite.jl

SQLite backend for Query.jl
Other
4 stars 2 forks source link

Slightly tweak the API #5

Closed davidanthoff closed 5 years ago

davidanthoff commented 5 years ago

Do you think this makes sense?

I mostly care about the final API, i.e. I think it would be good if both

db = Database(filename)

and

db = Database(SQLite.DB(filename))

worked.

I think SourceTables is too opaque of a name for end users.

codecov-io commented 5 years ago

Codecov Report

Merging #5 into master will increase coverage by 0.15%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage    69.5%   69.65%   +0.15%     
==========================================
  Files           8        8              
  Lines         200      201       +1     
==========================================
+ Hits          139      140       +1     
  Misses         61       61
Impacted Files Coverage Δ
src/QuerySQLite.jl 100% <ø> (ø) :arrow_up:
src/library.jl 61.11% <ø> (ø) :arrow_up:
src/source.jl 73.68% <100%> (+1.46%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f5c863a...858f848. Read the comment docs.

bramtayl commented 5 years ago

Ok sounds good