search

queryverse / VegaLite.jl

Julia bindings to Vega-Lite
Other
268 stars 39 forks source link

Make default for actionlinks() false #403

Open George9000 opened 3 years ago

George9000 commented 3 years ago

One of the actionlinks shown in the ellipsis button after VegaLite generates a figure in the browser is "Edit in Vega editor." Since this reaches out to https://vega.github.io/editor/#/ with the current figure and all data associated with it in the JSON spec passed to the editor, it poses a risk for those working with sensitive data. Apparently this data is kept client side only in the browser. However, it is better that someone working with the figure consider the potential risk and choose this option actively rather than misconstrue that the editor is local, when it is querying an external URL. So make actionlinks(false) the default in the package.

davidanthoff commented 2 years ago

I think we should probably just adopt Preferences.jl for something like that and make this a user configurable setting?

George9000 commented 2 years ago

I wasn't aware of Preferences.jl. That seems promising for a default setting. Is that too much overhead to change one setting though?