Closed argshook closed 1 year ago
in This PR:
localhost
127.0.0.1
The example code is used in other code bases to showcase how this client should be used.
It is also used with examples.manifest.yaml, which describes examples with interpolatable values.
examples.manifest.yaml
In particular, the examples.manifest.yaml has these:
addr: host: localhost port: 9009
when example code like ./examples/basic.js is interpolated with values from examples.manifest.yaml, the host part is missed.
./examples/basic.js
host
Thus, we should be consistent and in both examples.manifest.yaml and examples/*.js use as host either:
examples/*.js
This PR chooses localhost
in This PR:
localhost
instead of127.0.0.1
in examplesThe example code is used in other code bases to showcase how this client should be used.
It is also used with
examples.manifest.yaml
, which describes examples with interpolatable values.In particular, the
examples.manifest.yaml
has these:when example code like
./examples/basic.js
is interpolated with values fromexamples.manifest.yaml
, thehost
part is missed.Thus, we should be consistent and in both
examples.manifest.yaml
andexamples/*.js
use ashost
either:localhost
or127.0.0.1
This PR chooses
localhost