search

questdb / questdb-connect

SQLAchemy and Apache Superset extensions for QuestDB
Apache License 2.0
12 stars 4 forks source link

Username from URL is ignored #5

Closed jerrinot closed 1 year ago

jerrinot commented 1 year ago

It looks QuestDB-Connect ignores the username parsed from the URL and always defaults to "admin". This is caused by a wrong constant in our connect() function.

See the screenshot:

image

The line 94 should get() "user", not "username".

Reproducer

  1. Open hello_world.py and change the URL ("questdb://user:quest@localhost:8812/main")
  2. Run the Hello World example
  3. Watch Connect to still use the admin username when connecting to QuestDB instead of user as specified in the URL.

Expected behaviour The username from the URL should be used.

The fix is trivial, but I would send a PR with a fix, but I don't understand the test setup well enough to write a test for this.

marregui commented 1 year ago

release https://pypi.org/manage/project/questdb-connect/release/1.0.9/ should fix it.