search

questdb / questdb-connect

SQLAchemy and Apache Superset extensions for QuestDB
Apache License 2.0
14 stars 6 forks source link

SADeprecationWarning - Implement an import_dbapi() #9

Open PRICEKRAKEN opened 8 months ago

PRICEKRAKEN commented 8 months ago

SADeprecationWarning: The dbapi() classmethod on dialect classes has been renamed to import_dbapi(). Implement an import_dbapi() classmethod directly on class <class 'questdb_connect.dialect.QuestDBDialect'> to remove this warning; the old .dbapi() classmethod may be maintained for backwards compatibility.

PRICEKRAKEN commented 8 months ago

https://docs.sqlalchemy.org/en/20/core/internals.html#sqlalchemy.engine.default.DefaultDialect.import_dbapi

PRICEKRAKEN commented 8 months ago

https://github.com/questdb/questdb-connect/pull/10

PRICEKRAKEN commented 8 months ago

I see this project has requirement:

SQLAlchemy ('SQLAlchemy<=1.4.47')

After this merge it would be SQLAlchemy ('SQLAlchemy >= 2.0')

I run the questdb-connect module already with SQLAlchemy 2.0. Except the SADeprecationWarning i had no issues so far.

Can we work to bring this thing to SQLAlchemy 2.0 and onwards? Or would it break to much?