quexten / goldwarden

A feature-packed Bitwarden compatible desktop client
MIT License
759 stars 26 forks source link

browser biometrics not working in flatpaked vivaldi (works on native vivaldi) #260

Open zany130 opened 3 months ago

zany130 commented 3 months ago

as the title says, goldwarden setup browser biometrics (goldwarden is an alias for the full flatpak run command part for goldwarden as I only have goldwarden installed as a flatpak)

I tried manually creating the NativeMessagingHosts folder in /home/zany130/.var/app/com.vivaldi.Vivaldi/config/vivald/

with no luck.

I grabbed the com.8bit.bitwarden.json goldwarden-proxy.sh from a system with a natively installed Vivaldi. I modified com.8bit.bitwarden.json to point to /home/zany130/.var/app/com.vivaldi.Vivaldi/config/vivaldi/NativeMessagingHosts/goldwarden-proxy.sh in the path field with no luck either.

quexten commented 3 months ago

Can't get around flatpak restrictions of the browser until they implement a native messaging portal. Your best shot is "opening up the floodgates" permissions wise with flatseal, but i'm not sure what exactly is needed to get ipc to work.

(I think theoretically we could add an approach to proxy this out using dbus, but I'm not sure I'm ready to go this effort yet..)

ghost commented 3 months ago

Hey, somewhat unrelated, but would you mind helping me with getting biometrics working on Vivaldi? I use the native version, but I'm not sure how to set it up because the instructions for the extension haven't been updated.

zany130 commented 3 months ago

Hey, somewhat unrelated, but would you mind helping me with getting biometrics working on Vivaldi? I use the native version, but I'm not sure how to set it up because the instructions for the extension haven't been updated.

https://github.com/quexten/goldwarden/wiki/Browser-Biometric-Approval#chromium-based-browsers

followed this and it worked for me

quexten commented 3 months ago

Upstream linux biometrics is getting really close to being merged along with a large set of other biometrics improvements. After those have been merged this should not require these weird hacks anymore.

ghost commented 3 months ago

Hey, somewhat unrelated, but would you mind helping me with getting biometrics working on Vivaldi? I use the native version, but I'm not sure how to set it up because the instructions for the extension haven't been updated.

https://github.com/quexten/goldwarden/wiki/Browser-Biometric-Approval#chromium-based-browsers

followed this and it worked for me

That's very strange, since I did the same thing and it didn't work because the instructions haven't been updated to Manifest V3 (#236). Are you using an older version, then?

Upstream linux biometrics is getting really close to being merged along with a large set of other biometrics improvements. After those have been merged this should not require these weird hacks anymore.

Awesome! Can't wait for that, then!

zany130 commented 3 months ago

Ah I had the extension setup a while ago on my native Vivaldi install that's why. Actually that may be why I wasn't able to get it working now with flatpacked Vivaldi

rawkode commented 2 months ago

Native messaging portal is very very close to being merged.

https://github.com/flatpak/xdg-desktop-portal/pull/705