quic-go / masque-go

MASQUE: Proxying UDP in HTTP/3, RFC 9298
MIT License
81 stars 9 forks source link

Replace log using log/slog #76

Closed jiayx closed 1 week ago

jiayx commented 1 week ago

Replace log using log/slog

google-cla[bot] commented 1 week ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

jiayx commented 1 week ago

56

marten-seemann commented 1 week ago

This PR is missing the point of of slog/log. There no value in just replacing all log calls with slog.

The value comes from users being able to provide their own loggers.