unblock Connection Migration testing

quic-interop / quic-interop-runner

QUIC interop runner

Other

199 stars 78 forks source link

unblock Connection Migration testing #266

Open toidiu opened 3 years ago

toidiu commented 3 years ago

Creating a issue to track the effort required to enable Connection Migration interop testing.

Summary:

The next three tests are disabled due to Wireshark not being able to decrypt packets sent on the new path.

A comment in the repo states that tests related to connection migration are disabled because of missing support from Wireshark.

I found this issue in the Wireshark repo but i was last updated 6+ months ago: https://gitlab.com/wireshark/wireshark/-/issues/16915

Criteria for success:

[ ] Enable connection migration tests

toidiu commented 3 years ago

Open questions I have:

Is anyone currently working on this or is there a plan to pick up this feature?
How are implementations currently testing that connection migration works (I imagine a custom integration testing framework)?

marten-seemann commented 3 years ago

Can you try running these disabled tests with a current version of Wireshark? There's still a chance it got fix in the mean time, and the tracking issue wasn't properly updated. Otherwise, we'd probably have to poke the Wireshark guys to fix their code ;)

toidiu commented 3 years ago

Sure, let me enable the test and see if a recent version of Wireshark now supports the feature.

johnthacker commented 2 weeks ago

You should be able to enable those tests now (though some implementations will fail - an example posted to our bug did not issue a PATH_CHALLENGE when the port but not the IP address changed.)