Drop implementations that haven't been updated

quic-interop / quic-interop-runner

QUIC interop runner

Other

207 stars 81 forks source link

Drop implementations that haven't been updated #349

Open martinthomson opened 7 months ago

martinthomson commented 7 months ago

I notice that some of the implementations aren't being updated very often. Those implementations probably don't need to be run as often. They might even be hidden from the dashboard.

I didn't realize that neqo wasn't being updated, so maybe an email to a listed contact would be nice before doing this.

marten-seemann commented 7 months ago

First of all, we should notify implementations that haven't been updated in a long time, and encourage them to build their Docker image in CI. It's really easy, and there are plenty of GitHub Actions workflows around that can be copy-pasted.

I just went through the implementations and it looks that there are only two that haven't been updated in a long time (>2 months):

[ ] mvfst (1 year old): https://github.com/lnicco/mvfst-qns/issues/11
[ ] lsquic (10 months old): https://github.com/litespeedtech/lsquic/issues/492

lnicco commented 7 months ago

I just updated the mvfst image manually to unblock, it seems to be just a silly permission issue with the automation. I'll get it fixed soon, and later explore the Github Actions workflow you posted (thanks!)

marten-seemann commented 2 months ago

@lnicco Friendly ping, has there been any progress?

lnicco commented 2 months ago

@jbeshay moved the build to the main proxygen+mvfst repo and builds are generated weekly via github actions so the build is more stable and reliable. Are you still seeing issues with the images being outdated?

marten-seemann commented 2 months ago

@lnicco Sorry, I was looking at DockerHub, but you moved your registry to GitHub: https://github.com/facebook/proxygen/pkgs/container/proxygen%2Fmvfst-interop/versions?filters%5Bversion_type%5D=tagged. Seems like it's getting updated more frequently now.