search

quic-interop / quic-network-simulator

ns3-based network simulator for QUIC testing
Other
145 stars 44 forks source link

Publish linux/arm64 images #101

Closed WesleyRosenblum closed 2 years ago

WesleyRosenblum commented 2 years ago

This change upgrades to docker/build-push-action v2 (which supports building multi-platform images) and adds support for linux/arm64. This is needed for running the quic network simulator locally on ARM hardware, such as Apple M1.

WesleyRosenblum commented 2 years ago

Hi @marten-seemann, can this be merged?

marten-seemann commented 2 years ago

@WesleyRosenblum CI seems unhappy with this change. Can you check what's going on?

WesleyRosenblum commented 2 years ago

@WesleyRosenblum CI seems unhappy with this change. Can you check what's going on?

I can't see the exact issue, but I'm guessing it's because pull requests from forked repos do not have access to the secrets needed to login to Docker hub

marten-seemann commented 2 years ago

Ok, let's see how it behaves on master.