search

quic-interop / quic-network-simulator

ns3-based network simulator for QUIC testing
Other
145 stars 44 forks source link

build failing due to missing go binary #103

Closed marten-seemann closed 2 years ago

marten-seemann commented 2 years ago

See https://github.com/marten-seemann/quic-network-simulator/runs/6042075574?check_suite_focus=true.

This was introduced by #101. @WesleyRosenblum, could you please have a look?

WesleyRosenblum commented 2 years ago

Looks like there is a redundant step downloading Go that got left in by mistake: https://github.com/marten-seemann/quic-network-simulator/blob/dc7ae2f8d876b5ff6484fc320116eeba1d73d89e/sim/Dockerfile#L32

I can open a PR to fix it Monday if you don't get to it sooner. Sorry about that

WesleyRosenblum commented 2 years ago

@marten-seemann , this should fix it: #104